Skip to content

Add e2e automated testing#2005

Merged
khadgarmage merged 17 commits intoapache:devfrom
xingchun-chen:dev
Feb 26, 2020
Merged

Add e2e automated testing#2005
khadgarmage merged 17 commits intoapache:devfrom
xingchun-chen:dev

Conversation

@xingchun-chen
Copy link
Copy Markdown
Contributor

Tips

What is the purpose of the pull request

(For example: This pull request adds checkstyle plugin.)

Brief change log

(for example:)

  • Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added dolphinscheduler-dao tests for end-to-end.
  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 25, 2020

Codecov Report

Merging #2005 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2005      +/-   ##
============================================
- Coverage     31.99%   31.96%   -0.04%     
+ Complexity     1514     1511       -3     
============================================
  Files           311      311              
  Lines         15402    15402              
  Branches       1864     1864              
============================================
- Hits           4928     4923       -5     
- Misses         9965     9973       +8     
+ Partials        509      506       -3
Impacted Files Coverage Δ Complexity Δ
.../dolphinscheduler/api/service/ExecutorService.java 31.87% <0%> (ø) 16 <0> (ø) ⬇️
...er/server/worker/task/AbstractCommandExecutor.java 40.1% <0%> (ø) 14 <0> (ø) ⬇️
...common/utils/placeholder/TimePlaceholderUtils.java 4.56% <0%> (ø) 3 <0> (ø) ⬇️
...dolphinscheduler/api/service/ResourcesService.java 79.66% <0%> (ø) 67 <0> (ø) ⬇️
...er/server/master/runner/MasterSchedulerThread.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ler/common/utils/placeholder/PlaceholderUtils.java 66.66% <0%> (ø) 3 <0> (ø) ⬇️
.../dolphinscheduler/common/utils/ParameterUtils.java 57.57% <0%> (ø) 13 <0> (ø) ⬇️
...scheduler/alert/template/AlertTemplateFactory.java 42.85% <0%> (-14.29%) 2% <0%> (ø)
...he/dolphinscheduler/api/service/LoggerService.java 91.3% <0%> (-8.7%) 7% <0%> (-1%)
...inscheduler/common/thread/ThreadPoolExecutors.java 80% <0%> (-1.91%) 8% <0%> (-2%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623465e...b0f07ee. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Contributor

@khadgarmage khadgarmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

pom.xml Outdated
<groupId>org.apache.dolphinscheduler</groupId>
<artifactId>e2e</artifactId>
<version>${project.version}</version>
</dependency>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add scope test?

@khadgarmage khadgarmage merged commit 1cadb1a into apache:dev Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants