Skip to content

[New Feature] add conditions task #205#2003

Merged
qiaozhanwei merged 9 commits intoapache:devfrom
lenboo:dev-conditions
Feb 28, 2020
Merged

[New Feature] add conditions task #205#2003
qiaozhanwei merged 9 commits intoapache:devfrom
lenboo:dev-conditions

Conversation

@lenboo
Copy link
Copy Markdown
Contributor

@lenboo lenboo commented Feb 24, 2020

Tips

What is the purpose of the pull request

add new feature: conditions task

Brief change log

some refactor in master submit node;
add worker runner
frontend changes

@lenboo lenboo changed the title [New Feature] add conditions task [New Feature] add conditions task #205 Feb 24, 2020
@lenboo lenboo requested review from chongchongzi, davidzollo, lgcareer and qiaozhanwei and removed request for lgcareer and qiaozhanwei February 24, 2020 02:05
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 24, 2020 •
edited
Loading

Codecov Report

Merging #2003 into dev will increase coverage by 1.11%.
The diff coverage is 72.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev    #2003      +/-   ##
===========================================
+ Coverage     30.6%   31.72%   +1.11%     
- Complexity    1384     1512     +128     
===========================================
  Files          296      313      +17     
  Lines        15148    15528     +380     
  Branches      1832     1886      +54     
===========================================
+ Hits          4636     4926     +290     
- Misses       10054    10092      +38     
- Partials       458      510      +52
Impacted Files Coverage Δ Complexity Δ
...duler/server/worker/runner/TaskScheduleThread.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...pache/dolphinscheduler/common/enums/QueryType.java 0% <0%> (ø) 0 <0> (?)
...hinscheduler/common/utils/TaskParametersUtils.java 70% <0%> (-3.69%) 11 <0> (ø)
...lphinscheduler/server/worker/task/TaskManager.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...phinscheduler/server/worker/task/AbstractTask.java 11.59% <0%> (-0.35%) 2 <0> (ø)
...ommon/task/sqoop/sources/SourceMysqlParameter.java 100% <100%> (ø) 19 <19> (?)
...common/task/sqoop/sources/SourceHdfsParameter.java 100% <100%> (ø) 3 <3> (?)
...ommon/task/sqoop/targets/TargetMysqlParameter.java 100% <100%> (ø) 19 <19> (?)
...common/task/sqoop/targets/TargetHiveParameter.java 100% <100%> (ø) 17 <17> (?)
...common/task/sqoop/targets/TargetHdfsParameter.java 100% <100%> (ø) 13 <13> (?)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf9ee3...f9d0af1. Read the comment docs.

@break60
Copy link
Copy Markdown
Contributor

break60 commented Feb 24, 2020

frontend +1

@qiaozhanwei
Copy link
Copy Markdown
Contributor

qiaozhanwei commented Feb 25, 2020

1，compile error，plese re-run check or repair
2，conflicts please resolve

baoliang added 3 commits February 26, 2020 12:14
revert
4b5b1cd
update
f9d0af1
Merge branch 'dev' of github.com:apache/incubator-dolphinscheduler in…
419cd12 
…to dev-conditions

# Conflicts:
#	dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.vue
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 27, 2020

SonarCloud Quality Gate failed.

Bug C 10 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 15 Code Smells

0.8% 0.8% Coverage
0.4% 0.4% Duplication

qiaozhanwei
qiaozhanwei approved these changes Feb 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 0df7c67 into apache:dev Feb 28, 2020
@davidzollo davidzollo mentioned this pull request Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

@chongchongzi chongchongzi Awaiting requested review from chongchongzi

@lgcareer lgcareer Awaiting requested review from lgcareer

@davidzollo davidzollo Awaiting requested review from davidzollo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lenboo @codecov-io @break60 @qiaozhanwei