Skip to content

remove String.format for org.slf4j.Logger#2001

Merged
qiaozhanwei merged 1 commit intoapache:devfrom
gabry-lab:removeStrFormatForLogger
Feb 25, 2020
Merged

remove String.format for org.slf4j.Logger#2001
qiaozhanwei merged 1 commit intoapache:devfrom
gabry-lab:removeStrFormatForLogger

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab commented Feb 23, 2020

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 23, 2020

Codecov Report

Merging #2001 into dev will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #2001      +/-   ##
============================================
- Coverage     30.84%   30.82%   -0.02%     
+ Complexity     1382     1381       -1     
============================================
  Files           294      294              
  Lines         15022    15022              
  Branches       1810     1810              
============================================
- Hits           4633     4631       -2     
- Misses         9929     9931       +2     
  Partials        460      460
Impacted Files Coverage Δ Complexity Δ
...dolphinscheduler/api/service/ResourcesService.java 79.66% <0%> (ø) 67 <0> (ø) ⬇️
...ler/common/utils/placeholder/PlaceholderUtils.java 66.66% <0%> (ø) 3 <0> (ø) ⬇️
.../dolphinscheduler/api/service/ExecutorService.java 31.87% <0%> (ø) 16 <0> (ø) ⬇️
.../dolphinscheduler/common/utils/ParameterUtils.java 57.57% <0%> (ø) 13 <0> (ø) ⬇️
...er/server/worker/task/AbstractCommandExecutor.java 40.1% <0%> (ø) 14 <0> (ø) ⬇️
...common/utils/placeholder/TimePlaceholderUtils.java 4.56% <0%> (ø) 3 <0> (ø) ⬇️
...er/server/master/runner/MasterSchedulerThread.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...he/dolphinscheduler/api/service/LoggerService.java 91.3% <0%> (-8.7%) 7% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f2e5f...6c2964d. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 23, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@gabry-lab gabry-lab requested review from khadgarmage, lenboo and qiaozhanwei and removed request for khadgarmage, lenboo and qiaozhanwei February 23, 2020 09:33
Technoboy-
Technoboy- approved these changes Feb 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Eights-Li
Eights-Li approved these changes Feb 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Eights-Li Eights-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 5ca4862 into apache:dev Feb 25, 2020
@gabry-lab gabry-lab deleted the removeStrFormatForLogger branch February 26, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@Eights-Li Eights-Li Eights-Li approved these changes

@qiaozhanwei qiaozhanwei Awaiting requested review from qiaozhanwei

@lenboo lenboo Awaiting requested review from lenboo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gabry-lab @codecov-io @Technoboy- @Eights-Li @qiaozhanwei