Add ambari plugin #1469 by zhangchunyang1024 · Pull Request #1970 · apache/dolphinscheduler

zhangchunyang1024 · 2020-02-17T10:31:55Z

Add ambari plugin #1469

codecov-io · 2020-02-17T11:34:36Z

Codecov Report

Merging #1970 into dev will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##                dev   #1970      +/-   ##
===========================================
- Coverage     30.33%   30.3%   -0.04%     
  Complexity     1368    1368              
===========================================
  Files           294     294              
  Lines         14999   14999              
  Branches       1806    1806              
===========================================
- Hits           4550    4545       -5     
- Misses         9997   10004       +7     
+ Partials        452     450       -2

Impacted Files	Coverage Δ	Complexity Δ
...scheduler/alert/template/AlertTemplateFactory.java	`42.85% <0%> (-14.29%)`	`2% <0%> (ø)`
...er/server/worker/task/AbstractCommandExecutor.java	`40.1% <0%> (-2.04%)`	`14% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f2297...3165cb0. Read the comment docs.

Jave-Chen

amazing job

ambari_plugin/common-services/DOLPHIN/1.2.1/package/scripts/status_params.py

davidzollo · 2020-02-18T01:20:37Z

amazing

EricJoy2048

@githubzhangchunyang all python file need license description

ambari_plugin/common-services/DOLPHIN/1.2.1/configuration/dolphin-env.xml

ambari_plugin/common-services/DOLPHIN/1.2.1/metainfo.xml

ambari_plugin/common-services/DOLPHIN/1.2.1/package/alerts/alert_dolphin_scheduler_status.py

ambari_plugin/common-services/DOLPHIN/1.2.1/package/scripts/dolphin_alert_service.py

ambari_plugin/common-services/DOLPHIN/1.2.1/package/scripts/dolphin_worker_service.py

…fault empty 4. update alert message

sonarqubecloud · 2020-02-18T05:30:36Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

EricJoy2048

I reviewed

davidzollo

+1

davidzollo · 2020-02-22T07:59:23Z

@Jave-Chen ，can recheck again?

Jave-Chen

+1

EricJoy2048 · 2020-02-22T10:21:42Z

+1

EricJoy2048

+1

barntt77 · 2020-02-27T08:51:03Z

I want to make the source code into RPM package，but have a question。

thank for your help！

barntt77 · 2020-02-27T08:51:53Z

I want to make the source code into RPM package，but have a question。

thank for your help！

[INFO] dolphinscheduler ................................... SUCCESS [ 4.839 s]
[INFO] dolphinscheduler-ui ................................ SUCCESS [ 1.730 s]
[INFO] dolphinscheduler-common ............................ SUCCESS [ 31.917 s]
[INFO] dolphinscheduler-dao ............................... SUCCESS [ 29.429 s]
[INFO] dolphinscheduler-rpc ............................... SUCCESS [ 17.768 s]
[INFO] dolphinscheduler-alert ............................. SUCCESS [ 14.196 s]
[INFO] dolphinscheduler-server ............................ SUCCESS [ 23.985 s]
[INFO] dolphinscheduler-api ............................... SUCCESS [ 31.803 s]
[INFO] dolphinscheduler-dist .............................. FAILURE [ 21.314 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:03 min
[INFO] Finished at: 2020-02-27T16:24:10+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.2.0:attached-rpm (default) on project dolphinscheduler-dist: Source location C:\Users\ZhiFa\Desktop\idea\apache-dolphinscheduler-incubating-1.2.1-src-release\dolphinscheduler-dist..\dolphinschedul
er-ui\dist does not exist -> [Help 1]

EricJoy2048 · 2020-02-27T09:04:15Z

I want to make the source code into RPM package，but have a question。

thank for your help！

[INFO] dolphinscheduler ................................... SUCCESS [ 4.839 s]
[INFO] dolphinscheduler-ui ................................ SUCCESS [ 1.730 s]
[INFO] dolphinscheduler-common ............................ SUCCESS [ 31.917 s]
[INFO] dolphinscheduler-dao ............................... SUCCESS [ 29.429 s]
[INFO] dolphinscheduler-rpc ............................... SUCCESS [ 17.768 s]
[INFO] dolphinscheduler-alert ............................. SUCCESS [ 14.196 s]
[INFO] dolphinscheduler-server ............................ SUCCESS [ 23.985 s]
[INFO] dolphinscheduler-api ............................... SUCCESS [ 31.803 s]
[INFO] dolphinscheduler-dist .............................. FAILURE [ 21.314 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:03 min
[INFO] Finished at: 2020-02-27T16:24:10+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.2.0:attached-rpm (default) on project dolphinscheduler-dist: Source location C:\Users\ZhiFa\Desktop\idea\apache-dolphinscheduler-incubating-1.2.1-src-release\dolphinscheduler-dist..\dolphinschedul
er-ui\dist does not exist -> [Help 1]

Hi, I test the rpm command and found it`s a bug. Can you create a issue about it ? I will fix this bug.

barntt77 · 2020-02-28T01:13:06Z

I want to make the source code into RPM package，but have a question。

thank for your help！

[INFO] dolphinscheduler ................................... SUCCESS [ 4.839 s]
[INFO] dolphinscheduler-ui ................................ SUCCESS [ 1.730 s]
[INFO] dolphinscheduler-common ............................ SUCCESS [ 31.917 s]
[INFO] dolphinscheduler-dao ............................... SUCCESS [ 29.429 s]
[INFO] dolphinscheduler-rpc ............................... SUCCESS [ 17.768 s]
[INFO] dolphinscheduler-alert ............................. SUCCESS [ 14.196 s]
[INFO] dolphinscheduler-server ............................ SUCCESS [ 23.985 s]
[INFO] dolphinscheduler-api ............................... SUCCESS [ 31.803 s]
[INFO] dolphinscheduler-dist .............................. FAILURE [ 21.314 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:03 min
[INFO] Finished at: 2020-02-27T16:24:10+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.2.0:attached-rpm (default) on project dolphinscheduler-dist: Source location C:\Users\ZhiFa\Desktop\idea\apache-dolphinscheduler-incubating-1.2.1-src-release\dolphinscheduler-dist..\dolphinschedul
er-ui\dist does not exist -> [Help 1]

Hi, I test the rpm command and found it`s a bug. Can you create a issue about it ? I will fix this bug.

I'll create a issue about it immediately

barntt77 · 2020-02-28T01:19:03Z

I want to make the source code into RPM package，but have a question。

thank for your help！

[INFO] dolphinscheduler ................................... SUCCESS [ 4.839 s]
[INFO] dolphinscheduler-ui ................................ SUCCESS [ 1.730 s]
[INFO] dolphinscheduler-common ............................ SUCCESS [ 31.917 s]
[INFO] dolphinscheduler-dao ............................... SUCCESS [ 29.429 s]
[INFO] dolphinscheduler-rpc ............................... SUCCESS [ 17.768 s]
[INFO] dolphinscheduler-alert ............................. SUCCESS [ 14.196 s]
[INFO] dolphinscheduler-server ............................ SUCCESS [ 23.985 s]
[INFO] dolphinscheduler-api ............................... SUCCESS [ 31.803 s]
[INFO] dolphinscheduler-dist .............................. FAILURE [ 21.314 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:03 min
[INFO] Finished at: 2020-02-27T16:24:10+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.2.0:attached-rpm (default) on project dolphinscheduler-dist: Source location C:\Users\ZhiFa\Desktop\idea\apache-dolphinscheduler-incubating-1.2.1-src-release\dolphinscheduler-dist..\dolphinschedul
er-ui\dist does not exist -> [Help 1]

Hi, I test the rpm command and found it`s a bug. Can you create a issue about it ? I will fix this bug.

I'll create a issue about it immediately

issues #2038

zhangchunyang added 5 commits February 17, 2020 17:59

ambari plugin

61f6387

add readme.pdf

338a7ee

ambari plugin

6bd1f3c

add readme.md

169ac64

add readme.pdf

73411e3

zhangchunyang1024 requested review from EricJoy2048 and davidzollo February 17, 2020 10:33

Jave-Chen requested changes Feb 18, 2020

View reviewed changes

ambari_plugin/common-services/DOLPHIN/1.2.1/package/scripts/status_params.py Show resolved Hide resolved

davidzollo requested a review from qiaozhanwei February 18, 2020 01:20

EricJoy2048 reviewed Feb 18, 2020

View reviewed changes

1.add license 2. update master cardinality 3. nesessary paramaters de…

3165cb0

…fault empty 4. update alert message

zhangchunyang1024 requested a review from Jave-Chen February 18, 2020 05:42

EricJoy2048 self-requested a review February 19, 2020 01:56

EricJoy2048 reviewed Feb 19, 2020

View reviewed changes

davidzollo approved these changes Feb 21, 2020

View reviewed changes

Jave-Chen approved these changes Feb 22, 2020

View reviewed changes

EricJoy2048 approved these changes Feb 22, 2020

View reviewed changes

EricJoy2048 merged commit b4f2e5f into apache:dev Feb 22, 2020

zhangchunyang1024 deleted the dev branch April 8, 2020 11:55

Conversation

zhangchunyang1024 commented Feb 17, 2020

Uh oh!

codecov-io commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Jave-Chen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidzollo commented Feb 18, 2020

Uh oh!

EricJoy2048 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 18, 2020

Uh oh!

EricJoy2048 left a comment

Choose a reason for hiding this comment

Uh oh!

davidzollo left a comment

Choose a reason for hiding this comment

Uh oh!

davidzollo commented Feb 22, 2020

Uh oh!

Jave-Chen left a comment

Choose a reason for hiding this comment

Uh oh!

EricJoy2048 commented Feb 22, 2020

Uh oh!

EricJoy2048 left a comment

Choose a reason for hiding this comment

Uh oh!

barntt77 commented Feb 27, 2020

Uh oh!

barntt77 commented Feb 27, 2020

Uh oh!

EricJoy2048 commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barntt77 commented Feb 28, 2020

Uh oh!

barntt77 commented Feb 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-io commented Feb 17, 2020 •

edited

Loading

EricJoy2048 commented Feb 27, 2020 •

edited

Loading