Skip to content

Remove combined-server config in dolphinscheduler-daemon.sh file#1967

Merged
davidzollo merged 6 commits intoapache:devfrom
liwenhe1993:dev
Feb 17, 2020
Merged

Remove combined-server config in dolphinscheduler-daemon.sh file#1967
davidzollo merged 6 commits intoapache:devfrom
liwenhe1993:dev

Conversation

@liwenhe1993
Copy link
Copy Markdown
Member

@liwenhe1993 liwenhe1993 commented Feb 17, 2020

Deleted CombinedApplicationServer.java

So remove combined-server config in dolphinscheduler-daemon.sh file.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 17, 2020

Codecov Report

Merging #1967 into dev will increase coverage by 3.14%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1967      +/-   ##
============================================
+ Coverage     27.14%   30.28%   +3.14%     
+ Complexity     1383     1367      -16     
============================================
  Files           312      294      -18     
  Lines         16680    14999    -1681     
  Branches       2056     1806     -250     
============================================
+ Hits           4528     4543      +15     
+ Misses        11672    10006    -1666     
+ Partials        480      450      -30
Impacted Files Coverage Δ Complexity Δ
...nscheduler/dao/datasource/SQLServerDataSource.java 0% <ø> (ø) 0 <0> (?)
...hinscheduler/dao/datasource/PostgreDataSource.java 0% <ø> (ø) 0 <0> (?)
...phinscheduler/dao/datasource/OracleDataSource.java 0% <ø> (ø) 0 <0> (?)
...dolphinscheduler/server/monitor/ZKMonitorImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...olphinscheduler/dao/datasource/HiveDataSource.java 0% <ø> (ø) 0 <0> (?)
...hinscheduler/dao/datasource/DataSourceFactory.java 0% <ø> (ø) 0 <0> (?)
...e/dolphinscheduler/common/utils/Preconditions.java 0% <ø> (-63.16%) 0 <0> (-20)
...scheduler/dao/datasource/ClickHouseDataSource.java 0% <ø> (ø) 0 <0> (?)
...phinscheduler/api/service/TaskInstanceService.java 5.12% <ø> (ø) 2 <0> (ø) ⬇️
...che/dolphinscheduler/server/zk/ZKWorkerClient.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ccebbf...f959c8e. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

davidzollo
davidzollo approved these changes Feb 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit d7d7e95 into apache:dev Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liwenhe1993 @codecov-io @davidzollo