Skip to content

Support DS to create user and group in windows environment#1953

Merged
davidzollo merged 4 commits intoapache:devfrom
liwenhe1993:dev
Feb 16, 2020
Merged

Support DS to create user and group in windows environment#1953
davidzollo merged 4 commits intoapache:devfrom
liwenhe1993:dev

Conversation

@liwenhe1993
Copy link
Copy Markdown
Member

DS can not create user and group when runing DS in windows environment.

  1. implement user using net user
  2. implement group using net localgroup
  3. add unit test

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

3.4% 3.4% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
if anybody find bug,please submit issue

@davidzollo davidzollo merged commit d674eab into apache:dev Feb 16, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

if worker server support windows will be better,it will be a very big feature, looking forward your contribution.

best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants