Skip to content

process null check&add UT&remove duplicate code#1948

Merged
Jave-Chen merged 3 commits intoapache:devfrom
Eights-Li:dev-process
Feb 15, 2020
Merged

process null check&add UT&remove duplicate code#1948
Jave-Chen merged 3 commits intoapache:devfrom
Eights-Li:dev-process

Conversation

@Eights-Li
Copy link
Copy Markdown
Contributor

@Eights-Li Eights-Li commented Feb 13, 2020 •
edited
Loading

What is the purpose of the pull request

process null check&add UT&remove duplicate code

Brief change log

  • Add process null check
  • Add process definition UT
  • Add dagHelper UT
  • remove duplicate code in processDefinitionServiceTest

Verify this pull request

This pull request is already covered by existing tests, such as

  • ProcessDefinitionService
  • DagHelperTest

@Eights-Li
add process null check
6c90575 
Remove duplicate code in processDefinitionService
add processDefinitionService UT
@Eights-Li
add DagHelperTest to pom
77023ae
@davidzollo davidzollo requested a review from lenboo February 13, 2020 11:14
davidzollo
davidzollo approved these changes Feb 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 14, 2020 •
edited
Loading

Codecov Report

Merging #1948 into dev will increase coverage by 1.65%.
The diff coverage is 14.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1948      +/-   ##
============================================
+ Coverage     28.73%   30.39%   +1.65%     
+ Complexity     1487     1367     -120     
============================================
  Files           312      294      -18     
  Lines         16810    14964    -1846     
  Branches       2082     1800     -282     
============================================
- Hits           4831     4548     -283     
+ Misses        11471     9964    -1507     
+ Partials        508      452      -56
Impacted Files Coverage Δ Complexity Δ
...nscheduler/dao/datasource/SQLServerDataSource.java 0% <ø> (ø) 0 <0> (?)
...hinscheduler/dao/datasource/PostgreDataSource.java 0% <ø> (ø) 0 <0> (?)
...phinscheduler/dao/datasource/OracleDataSource.java 0% <ø> (ø) 0 <0> (?)
...olphinscheduler/dao/datasource/HiveDataSource.java 0% <ø> (ø) 0 <0> (?)
...uler/api/controller/ProcessInstanceController.java 2.43% <ø> (ø) 2 <0> (ø) ⬇️
...hinscheduler/dao/datasource/DataSourceFactory.java 0% <ø> (ø) 0 <0> (?)
...e/dolphinscheduler/common/utils/Preconditions.java 0% <ø> (-63.16%) 0 <0> (-20)
...dolphinscheduler/server/monitor/ZKMonitorImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...he/dolphinscheduler/server/utils/RemoveZKNode.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...phinscheduler/api/service/TaskInstanceService.java 5.12% <ø> (ø) 2 <0> (ø) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77023ae...87cb33b. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

80.4% 80.4% Coverage
0.0% 0.0% Duplication

lenboo
lenboo approved these changes Feb 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

lenboo
lenboo approved these changes Feb 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Jave-Chen Jave-Chen merged commit 90df148 into apache:dev Feb 15, 2020
@Eights-Li Eights-Li deleted the dev-process branch February 15, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

@lenboo lenboo lenboo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Eights-Li @codecov-io @davidzollo @lenboo @Jave-Chen