Skip to content

modify DataAnalysisServiceTest by mock#1941

Merged
samz406 merged 3 commits intoapache:devfrom
samz406:dev
Feb 12, 2020
Merged

modify DataAnalysisServiceTest by mock#1941
samz406 merged 3 commits intoapache:devfrom
samz406:dev

Conversation

@samz406
Copy link
Copy Markdown
Contributor

@samz406 samz406 commented Feb 12, 2020

For #1465
modify DataAnalysisServiceTest
modify DataAnalysisService

modify root pom

<include>**/api/service/DataAnalysisServiceTest.java</include>

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 12, 2020

Codecov Report

Merging #1941 into dev will increase coverage by 0.55%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev    #1941      +/-   ##
===========================================
+ Coverage     25.8%   26.35%   +0.55%     
- Complexity       0     1347    +1347     
===========================================
  Files          297      312      +15     
  Lines        14332    16642    +2310     
  Branches      2351     2048     -303     
===========================================
+ Hits          3698     4386     +688     
- Misses       10181    11784    +1603     
- Partials       453      472      +19
Impacted Files Coverage Δ Complexity Δ
...phinscheduler/api/service/DataAnalysisService.java 81.65% <66.66%> (+81.05%) 21 <0> (+21) ⬆️
...dolphinscheduler/common/utils/EncryptionUtils.java 50% <0%> (-50%) 2% <0%> (+2%)
...lphinscheduler/common/utils/SensitiveLogUtils.java 75% <0%> (-25%) 2% <0%> (+2%)
.../apache/dolphinscheduler/common/utils/ResInfo.java 78.04% <0%> (-14.55%) 10% <0%> (+10%)
...che/dolphinscheduler/common/utils/StringUtils.java 85.71% <0%> (-14.29%) 10% <0%> (+10%)
.../api/utils/exportprocess/TaskNodeParamFactory.java 66.66% <0%> (-13.34%) 3% <0%> (+3%)
...apache/dolphinscheduler/common/thread/Stopper.java 66.66% <0%> (-13.34%) 4% <0%> (+4%)
...heduler/server/master/runner/MasterExecThread.java 0% <0%> (-13.12%) 0% <0%> (ø)
...che/dolphinscheduler/common/enums/CommandType.java 88.88% <0%> (-11.12%) 2% <0%> (+2%)
...apache/dolphinscheduler/alert/utils/FuncUtils.java 91.66% <0%> (-8.34%) 5% <0%> (+5%)
... and 271 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb044a...735034c. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

khadgarmage
khadgarmage approved these changes Feb 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@khadgarmage khadgarmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@samz406 samz406 removed the request for review from Jave-Chen February 12, 2020 05:38
@samz406 samz406 merged commit e35e8be into apache:dev Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khadgarmage khadgarmage khadgarmage approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samz406 @codecov-io @khadgarmage