Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1928 +/- ##
==========================================
+ Coverage 25.01% 25.48% +0.47%
==========================================
Files 298 297 -1
Lines 14328 14330 +2
Branches 2350 2350
==========================================
+ Hits 3584 3652 +68
+ Misses 10299 10226 -73
- Partials 445 452 +7
Continue to review full report at Codecov.
|
Jave-Chen
reviewed
Feb 11, 2020
| @Test | ||
| public void testGetHeartBeatInfo() { | ||
| String info = ResInfo.getHeartBeatInfo(new Date()); | ||
| Assert.assertEquals(info.split(",").length, 7); |
Contributor
There was a problem hiding this comment.
There is a code smell in Sonar analysis: Swap these 2 arguments so they are in the correct order: expected value, actual value.
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1465
add ResInfoTest.java ut