Skip to content

Adapting partial code(file name start with C) to the sonar cloud rules#1918

Merged
davidzollo merged 4 commits intoapache:devfrom
gabry-lab:fixSonarC
Feb 13, 2020
Merged

Adapting partial code(file name start with C) to the sonar cloud rules#1918
davidzollo merged 4 commits intoapache:devfrom
gabry-lab:fixSonarC

Conversation

@gabry-lab
Copy link
Copy Markdown
Member

@gabry-lab gabry-lab commented Feb 9, 2020

Adapting partial code(file name start with C) to the sonar cloud rules

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 9, 2020 •
edited
Loading

Codecov Report

Merging #1918 into dev will increase coverage by 1.14%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1918      +/-   ##
============================================
+ Coverage     24.88%   26.02%   +1.14%     
- Complexity        0     1341    +1341     
============================================
  Files           298      313      +15     
  Lines         14388    17065    +2677     
  Branches       2371     2201     -170     
============================================
+ Hits           3580     4442     +862     
- Misses        10359    12167    +1808     
- Partials        449      456       +7
Impacted Files Coverage Δ Complexity Δ
...hinscheduler/dao/datasource/ConnectionFactory.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...e/dolphinscheduler/server/worker/WorkerServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...er/server/worker/task/AbstractCommandExecutor.java 40.5% <0%> (-2%) 14 <0> (+14)
...nscheduler/common/job/db/ClickHouseDataSource.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...che/dolphinscheduler/common/utils/CommonUtils.java 40% <0%> (+40%) 5 <0> (+5) ⬆️
...e/dolphinscheduler/server/master/MasterServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../dolphinscheduler/dao/utils/cron/CycleFactory.java 34.72% <0%> (+9.72%) 5 <0> (+5) ⬆️
.../apache/dolphinscheduler/api/utils/CheckUtils.java 61.53% <0%> (+7.37%) 19 <0> (+19) ⬆️
...dolphinscheduler/api/service/ResourcesService.java 79.66% <0%> (+0.04%) 67 <0> (+67) ⬆️
...r/common/task/subprocess/SubProcessParameters.java 16.66% <0%> (+16.66%) 1 <0> (+1) ⬆️
... and 277 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae622f...ec56695. Read the comment docs.

Jave-Chen
Jave-Chen approved these changes Feb 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jave-Chen Jave-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 good job

@gabry-lab gabry-lab requested a review from Jave-Chen February 12, 2020 03:04
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 12, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

44.9% 44.9% Coverage
0.3% 0.3% Duplication

davidzollo
davidzollo approved these changes Feb 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 44b7646 into apache:dev Feb 13, 2020
@gabry-lab gabry-lab deleted the fixSonarC branch February 13, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzollo davidzollo davidzollo approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@khadgarmage khadgarmage Awaiting requested review from khadgarmage

@Jave-Chen Jave-Chen Awaiting requested review from Jave-Chen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabry-lab @codecov-io @davidzollo @Jave-Chen