modify LoggerServiceTest UT by mock#1916
Merged
Jave-Chen merged 20 commits intoapache:devfrom Feb 11, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1916 +/- ##
==========================================
+ Coverage 24.27% 25.63% +1.35%
==========================================
Files 298 298
Lines 14388 14646 +258
Branches 2371 2482 +111
==========================================
+ Hits 3493 3754 +261
+ Misses 10468 10434 -34
- Partials 427 458 +31
Continue to review full report at Codecov.
|
Jave-Chen
reviewed
Feb 10, 2020
| @RunWith(SpringRunner.class) | ||
| @SpringBootTest(classes = ApiApplicationServer.class) | ||
| @RunWith(PowerMockRunner.class) | ||
| @PrepareForTest({LoggerService.class}) |
Contributor
There was a problem hiding this comment.
Repalce @RunWith(PowerMockRunner.class) with @RunWith(MockitoJUnitRunner.Silent.class) will get right coverage。
Contributor
Author
There was a problem hiding this comment.
modify @RunWith(MockitoJUnitRunner.class)
|
SonarCloud Quality Gate failed.
|
Contributor
|
Empty stirng code smell is acceptable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1465
modify LoggerServiceTest UT by mock
modify LoggerService
modify root pom
<include>**/api/service/LoggerServiceTest.java</include>