Skip to content

add ScriptRunnerTest.java unit test#1909

Merged
Jave-Chen merged 3 commits intoapache:devfrom
khadgarmage:ut-scriptrunner
Feb 9, 2020
Merged

add ScriptRunnerTest.java unit test#1909
Jave-Chen merged 3 commits intoapache:devfrom
khadgarmage:ut-scriptrunner

Conversation

@khadgarmage
Copy link
Copy Markdown
Contributor

#1465
add ScriptRunnerTest.java unit test

@Jave-Chen
Copy link
Copy Markdown
Contributor

try {
    Connection conn = Mockito.mock(Connection.class);
    Mockito.when(conn.getAutoCommit()).thenReturn(true);
    PreparedStatement st = Mockito.mock(PreparedStatement.class);
    Mockito.when(conn.createStatement()).thenReturn(st);
    ResultSet rs = Mockito.mock(ResultSet.class);
    Mockito.when(st.getResultSet()).thenReturn(rs);
    ResultSetMetaData md = Mockito.mock(ResultSetMetaData.class);
    Mockito.when(rs.getMetaData()).thenReturn(md);
    Mockito.when(md.getColumnCount()).thenReturn(1);
    Mockito.when(rs.next()).thenReturn(true, false);
    ScriptRunner s = new ScriptRunner(conn, true, true);
    s.runScript(new StringReader("select 1;"), "test_db");
    Mockito.verify(md).getColumnLabel(0);
} catch(Exception e) {
    Assert.assertNotNull(e);
}

how about encapsulate as a method ?

@khadgarmage khadgarmage requested a review from Jave-Chen February 9, 2020 02:10
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 9, 2020

Codecov Report

Merging #1909 into dev will increase coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1909      +/-   ##
==========================================
+ Coverage   23.72%   24.81%   +1.09%     
==========================================
  Files         299      299              
  Lines       14404    14602     +198     
  Branches     2374     2467      +93     
==========================================
+ Hits         3417     3624     +207     
+ Misses      10593    10525      -68     
- Partials      394      453      +59
Impacted Files Coverage Δ
...scheduler/alert/template/AlertTemplateFactory.java 42.85% <0%> (-14.29%) ⬇️
...heduler/server/master/runner/MasterExecThread.java 12.46% <0%> (-0.85%) ⬇️
.../dolphinscheduler/api/service/ExecutorService.java 34.45% <0%> (+2.57%) ⬆️
.../dolphinscheduler/dao/utils/cron/CycleFactory.java 25% <0%> (+25%) ⬆️
...dolphinscheduler/dao/utils/cron/AbstractCycle.java 50% <0%> (+50%) ⬆️
...he/dolphinscheduler/common/utils/ScriptRunner.java 58.04% <0%> (+58.04%) ⬆️
...he/dolphinscheduler/dao/utils/cron/CycleLinks.java 64.7% <0%> (+64.7%) ⬆️
...che/dolphinscheduler/dao/utils/cron/CronUtils.java 74.02% <0%> (+74.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fccbcc8...2f33a9e. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@Jave-Chen Jave-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Jave-Chen Jave-Chen merged commit bae622f into apache:dev Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants