Skip to content

fix: get taskAppId bug#1906

Merged
Technoboy- merged 1 commit intoapache:devfrom
wen-hemin:fixbug-get_taskInstId
Feb 7, 2020
Merged

fix: get taskAppId bug#1906
Technoboy- merged 1 commit intoapache:devfrom
wen-hemin:fixbug-get_taskInstId

Conversation

@wen-hemin
Copy link
Copy Markdown
Contributor

@wen-hemin wen-hemin commented Feb 7, 2020

The constructor has passed in an taskAppId, no need to get from taskAppId.

public AbstractCommandExecutor(Consumer<List<String>> logHandler,
                                   String taskDir, String taskAppId,int taskInstId,String tenantCode, String envFile,
                                   Date startTime, int timeout, Logger logger){
        this.logHandler = logHandler;
        this.taskDir = taskDir;
        this.taskAppId = taskAppId;
        this.taskInstId = taskInstId;
        this.tenantCode = tenantCode;

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 7, 2020

Codecov Report

Merging #1906 into dev will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1906      +/-   ##
==========================================
+ Coverage   23.66%   23.71%   +0.05%     
==========================================
  Files         299      299              
  Lines       14405    14404       -1     
  Branches     2374     2374              
==========================================
+ Hits         3409     3416       +7     
+ Misses      10605    10594      -11     
- Partials      391      394       +3
Impacted Files Coverage Δ
...er/server/worker/task/AbstractCommandExecutor.java 40.5% <ø> (+4.18%) ⬆️
...nscheduler/server/worker/task/datax/DataxTask.java 73.46% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b075d...7e0207d. Read the comment docs.

Technoboy-
Technoboy- approved these changes Feb 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Technoboy- Technoboy- merged commit fccbcc8 into apache:dev Feb 7, 2020
davidzollo
davidzollo approved these changes Feb 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@davidzollo davidzollo davidzollo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wen-hemin @codecov-io @Technoboy- @davidzollo