Skip to content

combine logback config of master/worker/alert/api server to one#1898

Merged
davidzollo merged 34 commits intoapache:devfrom
davidzollo:dev
Feb 6, 2020
Merged

combine logback config of master/worker/alert/api server to one#1898
davidzollo merged 34 commits intoapache:devfrom
davidzollo:dev

Conversation

@davidzollo
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo commented Feb 5, 2020

combine logback config of master/worker/alert/api server to one

DanielLeens and others added 30 commits September 5, 2019 17:48
@DanielLeens
Merge remote-tracking branch 'upstream/dev' into dev
46b6d85
@DanielLeens
Merge remote-tracking branch 'upstream/dev' into dev
a1892c8
@DanielLeens
Merge remote-tracking branch 'upstream/dev' into dev
26f2829
@DanielLeens
update README about DolphinScheduler
b3dae19
Update issue templates
fb786d8
@davidzollo
update
1e540fb
@davidzollo
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
c8b4749 
…duler into dev
@davidzollo
update
6086749
@davidzollo
regularize api pom xml
5250ab0 
update rpc maven compile to 1.8
@davidzollo
regularize api pom xml
dcc2ff6
@davidzollo
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
68f1e7e 
…duler into dev
@davidzollo
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
04f8fe8 
…duler into dev
@davidzollo
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
dd03d78 
…duler into dev

# Conflicts:
#	dolphinscheduler-api/pom.xml
@davidzollo
Merge branch 'dev' into dev
c60b7b7
@davidzollo
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
be8aff3 
…duler into dev
@davidzollo
Merge remote-tracking branch 'origin/dev' into dev
6c4debe 
# Conflicts:
#	dolphinscheduler-api/pom.xml
@davidzollo
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
5dbaa52 
…duler into dev
@davidzollo
change commons.lang3.StringUtils to common.utils.StringUtils
9169a7c
@davidzollo
update pom.xml
7c1b37a
@davidzollo
Merge branch 'dev' into dev
a2555c1
@davidzollo
update
f425001
@davidzollo
update
ce330ca
@davidzollo
Merge remote-tracking branch 'origin/dev' into dev
affe665
@davidzollo
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
293039f 
…duler into dev
@davidzollo
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
aa191c2 
…duler into dev
@davidzollo
correct equals method
f9afc0a
@davidzollo
update code
c6d1557
@davidzollo
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
c3ea38f 
…duler into dev
@davidzollo
jasper-runtime is needed when api server start
39e98b2
@davidzollo
jasper-runtime jar is needed when api server start
db45500
@Jave-Chen
Copy link
Copy Markdown
Contributor

Jave-Chen commented Feb 5, 2020

UT coverage analysis need add include record at pom.xml . Like this:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-surefire-plugin</artifactId>
    <version>${maven-surefire-plugin.version}</version>
    <configuration>
        <includes>
             ...
            <!-- add here -->
            <include>**/path/to/new/file.java</include>
        </includes>
        <!-- <skip>true</skip> -->
    </configuration>
</plugin>

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 5, 2020 •
edited
Loading

Codecov Report

Merging #1898 into dev will decrease coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #1898     +/-   ##
=========================================
- Coverage   22.47%   21.87%   -0.6%     
=========================================
  Files         296      296             
  Lines       14176    14261     +85     
  Branches     2340     2376     +36     
=========================================
- Hits         3186     3120     -66     
- Misses      10635    10783    +148     
- Partials      355      358      +3
Impacted Files Coverage Δ
...er/server/worker/task/AbstractCommandExecutor.java 0% <ø> (ø) ⬆️
...phinscheduler/common/log/TaskLogDiscriminator.java 70% <ø> (ø)
...e/dolphinscheduler/common/log/MasterLogFilter.java 16.66% <ø> (ø)
...he/dolphinscheduler/server/utils/ProcessUtils.java 0% <ø> (ø) ⬆️
...e/dolphinscheduler/common/log/WorkerLogFilter.java 16.66% <ø> (ø)
...che/dolphinscheduler/common/log/TaskLogFilter.java 16.66% <ø> (ø)
...duler/server/worker/runner/TaskScheduleThread.java 0% <ø> (ø) ⬆️
...lphinscheduler/common/utils/SensitiveLogUtils.java 100% <ø> (ø)
...che/dolphinscheduler/common/utils/LoggerUtils.java 92.85% <100%> (ø)
...inscheduler/common/log/SensitiveDataConverter.java 94.11% <100%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d1557...8ab680f. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

qiaozhanwei
qiaozhanwei approved these changes Feb 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit c63cd3e into apache:dev Feb 6, 2020
@davidzollo davidzollo mentioned this pull request Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidzollo @Jave-Chen @codecov-io @qiaozhanwei @DanielLeens