Skip to content

change datasource null check position#1883

Merged
qiaozhanwei merged 1 commit intoapache:devfrom
Eights-Li:dev-null
Feb 3, 2020
Merged

change datasource null check position#1883
qiaozhanwei merged 1 commit intoapache:devfrom
Eights-Li:dev-null

Conversation

@Eights-Li
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

change datasource null check position

Brief change log

  • Edit server/worker/task/sql/SqlTask

Verify this pull request

This pull request is code cleanup without any test coverage.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1883 into dev will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1883      +/-   ##
==========================================
- Coverage   22.48%   22.47%   -0.01%     
==========================================
  Files         296      296              
  Lines       14176    14176              
  Branches     2340     2340              
==========================================
- Hits         3187     3186       -1     
- Misses      10633    10635       +2     
+ Partials      356      355       -1
Impacted Files Coverage Δ
...lphinscheduler/server/worker/task/sql/SqlTask.java 0% <0%> (ø) ⬆️
...scheduler/alert/template/AlertTemplateFactory.java 42.85% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0debe...2fa0662. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 78bfe91 into apache:dev Feb 3, 2020
@Eights-Li Eights-Li deleted the dev-null branch February 4, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants