Skip to content

add hashCode#1882

Merged
davidzollo merged 1 commit intoapache:devfrom
Eights-Li:dev
Feb 3, 2020
Merged

add hashCode#1882
davidzollo merged 1 commit intoapache:devfrom
Eights-Li:dev

Conversation

@Eights-Li
Copy link
Copy Markdown
Contributor

What is the purpose of the pull request

Class overrides equals() and should therefore also override hashCode()

Brief change log

  • Edit api/utils/ZooKeeperState
  • Edit common/model/DateInterval
  • Edit common/model/TaskNodeRelation
  • Edit server/master/runner/MasterTaskExecThread

Verify this pull request

This pull request is code cleanup without any test coverage.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo
Copy link
Copy Markdown
Contributor

davidzollo commented Feb 3, 2020

I think no need more people review

@davidzollo davidzollo merged commit 5169689 into apache:dev Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants