Skip to content

Fix return, obj error#1855

Merged
davidzollo merged 1 commit intoapache:devfrom
Jave-Chen:bcai-dev-fix-bug-20200117
Jan 17, 2020
Merged

Fix return, obj error#1855
davidzollo merged 1 commit intoapache:devfrom
Jave-Chen:bcai-dev-fix-bug-20200117

Conversation

@Jave-Chen
Copy link
Copy Markdown
Contributor

  1. Fix ExecutorService.java return error, add return 0
  2. Fix DateInterval.java obj error, replace o to obj

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (dev@d371745). Click here to learn what that means.
The diff coverage is 25%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #1855   +/-   ##
======================================
  Coverage       ?   22.46%           
======================================
  Files          ?      296           
  Lines          ?    14181           
  Branches       ?     2342           
======================================
  Hits           ?     3186           
  Misses         ?    10639           
  Partials       ?      356
Impacted Files Coverage Δ
.../dolphinscheduler/api/service/ExecutorService.java 31.6% <100%> (ø)
...he/dolphinscheduler/common/model/DateInterval.java 14.28% <14.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d371745...48a3b15. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

58.3% 58.3% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 16913ba into apache:dev Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants