Skip to content

Api module relp server module/1756#1766

Merged
davidzollo merged 3 commits intoapache:devfrom
liwenhe1993:api-module-relp-server-module/1756
Jan 20, 2020
Merged

Api module relp server module/1756#1766
davidzollo merged 3 commits intoapache:devfrom
liwenhe1993:api-module-relp-server-module/1756

Conversation

@liwenhe1993
Copy link
Copy Markdown
Member

Tips

What is the purpose of the pull request

(For example: This pull request adds checkstyle plugin.)

Brief change log

(for example:)

  • Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added dolphinscheduler-dao tests for end-to-end.
  • Added CronUtilsTest to verify the change.
  • Manually verified the change by testing locally.

liwenhe1993 and others added 2 commits January 8, 2020 10:11
1. Remove server module and add dao module.
2. Move quartz in server module to dao module.
3. Update config and class.
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1766 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1766      +/-   ##
==========================================
- Coverage   20.22%   20.22%   -0.01%     
==========================================
  Files         290      290              
  Lines       14082    14080       -2     
  Branches     2376     2376              
==========================================
- Hits         2848     2847       -1     
+ Misses      10908    10907       -1     
  Partials      326      326
Impacted Files Coverage Δ
...e/dolphinscheduler/server/master/MasterServer.java 0% <ø> (ø) ⬆️
...olphinscheduler/api/CombinedApplicationServer.java 0% <ø> (ø) ⬆️
...olphinscheduler/dao/quartz/ProcessScheduleJob.java 0% <ø> (ø)
...dolphinscheduler/api/service/SchedulerService.java 0% <ø> (ø) ⬆️
...e/dolphinscheduler/dao/quartz/QuartzExecutors.java 0% <ø> (ø)
...nscheduler/dao/quartz/DruidConnectionProvider.java 0% <ø> (ø)
...scheduler/alert/template/AlertTemplateFactory.java 42.85% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995b5ca...fb93bc4. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 8, 2020

SonarCloud Quality Gate failed.

Bug C 2 Bugs
Vulnerability B 7 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
#1756

@Technoboy-
Copy link
Copy Markdown
Contributor

@qiaozhanwei

Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei
Copy link
Copy Markdown
Contributor

please resolve conflict

@davidzollo davidzollo merged commit 30db5c1 into apache:dev Jan 20, 2020
@davidzollo
Copy link
Copy Markdown
Contributor

please resolve conflict

I resolved

@davidzollo
Copy link
Copy Markdown
Contributor

excellent

Please send mail to me(dailidong66@gmail.com) or add my wechat: 510570367, we can take deep communication , when added, please tell me your github id, thx

looking forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants