Fix bug: NullPointerException etc.#1721
Merged
davidzollo merged 5 commits intoapache:devfrom Jan 17, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1721 +/- ##
==========================================
- Coverage 21.02% 20.99% -0.03%
==========================================
Files 292 292
Lines 14069 14082 +13
Branches 2321 2325 +4
==========================================
- Hits 2958 2957 -1
- Misses 10775 10788 +13
- Partials 336 337 +1
Continue to review full report at Codecov.
|
Technoboy-
reviewed
Jan 6, 2020
| return startTime.equals(dateInterval.getStartTime()) && | ||
| endTime.equals(dateInterval.getEndTime()); | ||
| }catch (Exception e){ | ||
| if (obj != null) { |
Contributor
There was a problem hiding this comment.
why use try/catch surround equals method?
Contributor
Author
There was a problem hiding this comment.
check whether obj is null
Contributor
|
please resolve conflicts |
|
SonarCloud Quality Gate failed.
|
Contributor
Author
done |
refactor equals method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
#1720 Fix bug: NullPointerException etc.
Brief change log