Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause. #1716
Merged
Technoboy- merged 4 commits intoapache:devfrom Jan 17, 2020
Merged
Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause. #1716Technoboy- merged 4 commits intoapache:devfrom
Technoboy- merged 4 commits intoapache:devfrom
Conversation
… a "finally" clause.
davidzollo
reviewed
Jan 5, 2020
Contributor
davidzollo
left a comment
There was a problem hiding this comment.
-1
suggestion: please add unit test， you will find the question
...heduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
Jan 5, 2020
...hinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/FourLetterWordMain.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #1716 +/- ##
==========================================
+ Coverage 17.15% 21.38% +4.22%
==========================================
Files 285 293 +8
Lines 13900 14047 +147
Branches 2267 2319 +52
==========================================
+ Hits 2385 3004 +619
+ Misses 11240 10716 -524
- Partials 275 327 +52
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed.
|
davidzollo
approved these changes
Jan 14, 2020
...heduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
Outdated
Show resolved
Hide resolved
...hinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/FourLetterWordMain.java
Outdated
Show resolved
Hide resolved
...hinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/FourLetterWordMain.java
Show resolved
Hide resolved
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
#1714
Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause.
Brief change log