Skip to content

[DSIP-82][Master/Worker] Use FAILOVER_FINISH_NODES to avoid duplicate workflow/task when failover#16821

Merged
caishunfeng merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_removeWaittingStrategy
Nov 20, 2024
Merged

[DSIP-82][Master/Worker] Use FAILOVER_FINISH_NODES to avoid duplicate workflow/task when failover#16821
caishunfeng merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_removeWaittingStrategy

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun commented Nov 19, 2024 •
edited
Loading

Purpose of the pull reques

related issue #16759
close #16825

Brief change log

  • Remove waiting strategy
  • Add delay time to failover event and check the server health to avoid failover reconnect server
  • Use FailoverFinishNodes to avoid one node has been failovered but it reconnect to registry.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun changed the title [Fix-16759][Master/Worker] Remove waiting strategy [Fix-16759][Master/Worker] Fix reconnect to registry might cause task duplicate running Nov 19, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeWaittingStrategy branch from 9a195bd to 978665e Compare November 19, 2024 15:23
@SbloodyS SbloodyS added this to the 3.3.0 milestone Nov 20, 2024
SbloodyS
SbloodyS previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeWaittingStrategy branch from 978665e to 91638d0 Compare November 20, 2024 04:07
SbloodyS
SbloodyS previously approved these changes Nov 20, 2024
View reviewed changes
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeWaittingStrategy branch 3 times, most recently from bdc06d8 to b6e52fc Compare November 20, 2024 05:50
@ruanwenjun ruanwenjun changed the title [Fix-16759][Master/Worker] Fix reconnect to registry might cause task duplicate running [DSIP-82][Master/Worker] Use FAILOVER_FINISH_NODES to avoid duplicate workflow/task when failover Nov 20, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeWaittingStrategy branch from b6e52fc to 3a61665 Compare November 20, 2024 06:09
caishunfeng
caishunfeng previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

SbloodyS
SbloodyS previously approved these changes Nov 20, 2024
View reviewed changes
@ruanwenjun ruanwenjun dismissed stale reviews from SbloodyS and caishunfeng via 6cb0713 November 20, 2024 06:45
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeWaittingStrategy branch from 3a61665 to 6cb0713 Compare November 20, 2024 06:45
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeWaittingStrategy branch from 6cb0713 to e7e788f Compare November 20, 2024 07:10
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeWaittingStrategy branch from e7e788f to 60ae3fb Compare November 20, 2024 07:13
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
27.4% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@caishunfeng caishunfeng merged commit 9856453 into apache:dev Nov 20, 2024
@ruanwenjun ruanwenjun deleted the dev_wenjun_removeWaittingStrategy branch November 20, 2024 08:08
@ruanwenjun ruanwenjun mentioned this pull request Aug 26, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@SbloodyS SbloodyS SbloodyS approved these changes

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@Gallardot Gallardot Awaiting requested review from Gallardot Gallardot is a code owner

Assignees

@ruanwenjun ruanwenjun

Labels

backend document test

Projects

None yet

Milestone

3.3.0-alpha

Development

Successfully merging this pull request may close these issues.

[DSIP-82][Master/Worker] Use FAILOVER_FINISH_NODES to avoid duplicate workflow/task when failover

4 participants

@ruanwenjun @caishunfeng @SbloodyS @github-advanced-security