Skip to content

[DSIP-70] Deprecated upgrade code of 1.x and 2.x in 3.3.0-release#16551

Merged
SbloodyS merged 6 commits intoapache:devfrom
SbloodyS:dsip_70
Aug 30, 2024
Merged

[DSIP-70] Deprecated upgrade code of 1.x and 2.x in 3.3.0-release#16551
SbloodyS merged 6 commits intoapache:devfrom
SbloodyS:dsip_70

Conversation

@SbloodyS
Copy link
Copy Markdown
Member

Purpose of the pull request

close #16543

Brief change log

  • Deprecated upgrade code of 1.x and 2.x in 3.3.0-release since we no longer support direct upgrades to 3.3.0 from these versions. Users can upgrade to 3.0.0 first and then 3.3.0.
  • Add some upgrade docs.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove the sql under dao

@SbloodyS
Copy link
Copy Markdown
Member Author

Should remove the sql under dao

Done. PTAL.

Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie
Copy link
Copy Markdown
Member

I have a question here, why we not support upgrade 330 before 300? @SbloodyS

@SbloodyS
Copy link
Copy Markdown
Member Author

I have a question here, why we not support upgrade 330 before 300? @SbloodyS

We will uniformly name process in code as workflow in #16515 . After that, there will be some incompatible.

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarqubecloud
Copy link
Copy Markdown

@SbloodyS SbloodyS merged commit ceb711b into apache:dev Aug 30, 2024
@SbloodyS SbloodyS deleted the dsip_70 branch August 30, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DSIP-70] Deprecated upgrade code of 1.x and 2.x in 3.3.0-release

3 participants