Skip to content

[DSIP-34] Change required_approving_review_count to 2#15914

Merged
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_changeApCountTo2
Apr 25, 2024
Merged

[DSIP-34] Change required_approving_review_count to 2#15914
ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_changeApCountTo2

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun commented Apr 25, 2024

Purpose of the pull request

close #15913

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot removed the CI&CD label Apr 25, 2024
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly CI&CD labels Apr 25, 2024
Copy link
Copy Markdown
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍SGTM!

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun self-assigned this Apr 25, 2024
@sonarqubecloud
Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud

@ruanwenjun ruanwenjun merged commit d1135ea into apache:dev Apr 25, 2024
@ruanwenjun ruanwenjun deleted the dev_wenjun_changeApCountTo2 branch April 25, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI&CD improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DSIP-34] Change required_approving_review_count to 2

3 participants