[DSIP-28] Donnot scan whole project beans under classpath#15874
Merged
ruanwenjun merged 1 commit intoapache:devfrom Apr 19, 2024
Merged
[DSIP-28] Donnot scan whole project beans under classpath#15874ruanwenjun merged 1 commit intoapache:devfrom
ruanwenjun merged 1 commit intoapache:devfrom
Conversation
d8eb823 to
108fd39
Compare
108fd39 to
85b09fd
Compare
3758120 to
9cd3f14
Compare
qingwli
reviewed
Apr 19, 2024
...pi/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15874 +/- ##
============================================
+ Coverage 39.52% 39.60% +0.07%
- Complexity 5002 5015 +13
============================================
Files 1348 1349 +1
Lines 45674 45578 -96
Branches 4896 4886 -10
============================================
- Hits 18053 18051 -2
+ Misses 25698 25609 -89
+ Partials 1923 1918 -5 ☔ View full report in Codecov by Sentry. |
rickchengx
approved these changes
Apr 19, 2024
Contributor
rickchengx
left a comment
There was a problem hiding this comment.
LGTM, This avoids loading unnecessary beans
9cd3f14 to
d8aeb9f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #15877
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md