[Improvement][RemoteLogging] Move init into loghandler#15780
Merged
davidzollo merged 2 commits intoapache:devfrom Mar 31, 2024
Merged
[Improvement][RemoteLogging] Move init into loghandler#15780davidzollo merged 2 commits intoapache:devfrom
davidzollo merged 2 commits intoapache:devfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15780 +/- ##
============================================
- Coverage 39.16% 39.16% -0.01%
+ Complexity 4867 4866 -1
============================================
Files 1316 1316
Lines 44978 44978
Branches 4803 4803
============================================
- Hits 17617 17615 -2
- Misses 25477 25478 +1
- Partials 1884 1885 +1 ☔ View full report in Codecov by Sentry. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
see #15769
move init inside contructor.
Brief change log
see #15769
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md