Skip to content

fix issue:1477 some tasks would be running all the time when db delayed(#1477)#1501

Merged
qiaozhanwei merged 3 commits intoapache:devfrom
lenboo:dev-issue-1477
Dec 18, 2019
Merged

fix issue:1477 some tasks would be running all the time when db delayed(#1477)#1501
qiaozhanwei merged 3 commits intoapache:devfrom
lenboo:dev-issue-1477

Conversation

@lenboo
Copy link
Copy Markdown
Contributor

@lenboo lenboo commented Dec 17, 2019 •
edited
Loading

What is the purpose of the pull request

fix issue:1477 some tasks would be running all the time when db delayed

  • split the submit to two part: submit to db and submit to queue.
  • while(true) retry submit task to db and queue.

Verify this pull request

server model is difficult for ut because some db operations. there maybe some refactors in the feature.
This pull request is code cleanup without any test coverage.

@lenboo lenboo marked this pull request as ready for review December 17, 2019 08:04
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 17, 2019 •
edited
Loading

Codecov Report

Merging #1501 into dev will increase coverage by 2.49%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev   #1501      +/-   ##
========================================
+ Coverage   2.77%   5.27%   +2.49%     
========================================
  Files        272     272              
  Lines      13602   13617      +15     
  Branches    2160    2165       +5     
========================================
+ Hits         378     718     +340     
+ Misses     13205   12858     -347     
- Partials      19      41      +22
Impacted Files Coverage Δ
.../org/apache/dolphinscheduler/common/Constants.java 0% <ø> (ø) ⬆️
...server/master/runner/MasterBaseTaskExecThread.java 0% <0%> (ø) ⬆️
...va/org/apache/dolphinscheduler/dao/ProcessDao.java 0% <0%> (ø) ⬆️
...ler/server/master/runner/MasterTaskExecThread.java 0% <0%> (ø) ⬆️
...dolphinscheduler/common/queue/TaskQueueZkImpl.java 0% <0%> (ø) ⬆️
.../server/worker/task/processdure/ProcedureTask.java 0% <0%> (ø) ⬆️
...cheduler/server/worker/task/python/PythonTask.java 0% <0%> (ø) ⬆️
...nscheduler/server/worker/task/shell/ShellTask.java 0% <0%> (ø) ⬆️
...er/server/worker/task/dependent/DependentTask.java 0% <0%> (ø) ⬆️
...hinscheduler/server/worker/task/http/HttpTask.java 0% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8d74a...1379d3d. Read the comment docs.

lgcareer
lgcareer approved these changes Dec 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lgcareer lgcareer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

qiaozhanwei
qiaozhanwei approved these changes Dec 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@qiaozhanwei qiaozhanwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qiaozhanwei qiaozhanwei merged commit 21cb38d into apache:dev Dec 18, 2019
@lenboo lenboo deleted the dev-issue-1477 branch January 9, 2020 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgcareer lgcareer lgcareer approved these changes

@qiaozhanwei qiaozhanwei qiaozhanwei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lenboo @codecov-io @lgcareer @qiaozhanwei