Skip to content

Add ExcelUtilsTest.java , the unit test for ExcelUtils#1500

Merged
khadgarmage merged 2 commits intoapache:devfrom
nauu:newfeature/#1465-ExcelUtilsUT
Dec 17, 2019
Merged

Add ExcelUtilsTest.java , the unit test for ExcelUtils#1500
khadgarmage merged 2 commits intoapache:devfrom
nauu:newfeature/#1465-ExcelUtilsUT

Conversation

@nauu
Copy link
Copy Markdown
Contributor

@nauu nauu commented Dec 17, 2019

What is the purpose of the pull request

For #1465 .
Add ExcelUtilsTest.java , the unit test for ExcelUtils.

Brief change log

  • Add ExcelUtilsTest.java
  • Edit ExcelUtils.java
  • Add /alert/utils/ExcelUtilsTest.java to root pom.xml

Verify this pull request

This change added tests and can be verified as follows:

  • Added ExcelUtilsTest to verify the change.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 17, 2019

Codecov Report

Merging #1500 into dev will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev   #1500      +/-   ##
========================================
+ Coverage   5.28%    5.6%   +0.32%     
========================================
  Files        272     272              
  Lines      13598   13594       -4     
  Branches    2158    2158              
========================================
+ Hits         718     762      +44     
+ Misses     12839   12787      -52     
- Partials      41      45       +4
Impacted Files Coverage Δ
...pache/dolphinscheduler/alert/utils/ExcelUtils.java 78% <100%> (+78%) ⬆️
...apache/dolphinscheduler/alert/utils/JSONUtils.java 50% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2212b9d...2f09918. Read the comment docs.

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@khadgarmage khadgarmage merged commit 5f09349 into apache:dev Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants