Add common utils CollectionUtils.java DateUtils.java unit test#1496
Merged
khadgarmage merged 5 commits intoapache:devfrom Dec 17, 2019
Merged
Add common utils CollectionUtils.java DateUtils.java unit test#1496khadgarmage merged 5 commits intoapache:devfrom
khadgarmage merged 5 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1496 +/- ##
=======================================
+ Coverage 2.77% 5.28% +2.5%
=======================================
Files 272 272
Lines 13598 13598
Branches 2158 2158
=======================================
+ Hits 378 718 +340
+ Misses 13201 12839 -362
- Partials 19 41 +22
Continue to review full report at Codecov.
|
lgcareer
approved these changes
Dec 17, 2019
Contributor
lgcareer
left a comment
There was a problem hiding this comment.
stringToMap Method need consider the initial capacity and load factor of the hashmap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
#1465
collectionutils.java
dateutils.java