#839 enhancement : add Spark Task Component can switch Spark Version#1494
Merged
khadgarmage merged 4 commits intoapache:devfrom Dec 17, 2019
Eights-Li:dev
Merged
#839 enhancement : add Spark Task Component can switch Spark Version#1494khadgarmage merged 4 commits intoapache:devfrom Eights-Li:dev
khadgarmage merged 4 commits intoapache:devfrom
Eights-Li:dev
Conversation
added 3 commits
December 10, 2019 20:35
add Spark Version in Spark Component
add license
2 add spark version param check
Codecov Report
@@ Coverage Diff @@
## dev #1494 +/- ##
========================================
+ Coverage 2.69% 2.77% +0.07%
========================================
Files 271 272 +1
Lines 13593 13602 +9
Branches 2159 2160 +1
========================================
+ Hits 367 378 +11
+ Misses 13209 13205 -4
- Partials 17 19 +2
Continue to review full report at Codecov.
|
khadgarmage
requested changes
Dec 17, 2019
| @Test | ||
| public void testSparkTaskInit() { | ||
|
|
||
| TaskProps taskProps = new TaskProps(); |
Contributor
There was a problem hiding this comment.
ut has no assert check?
Contributor
Author
There was a problem hiding this comment.
i will add assert check for this
khadgarmage
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This pull request adds spark task component can swithch spark version
Brief change log
Verify this pull request
This change added tests and can be verified as follows: