[Improvement][API Test] Add API tests for worker group related APIs#13936
[Improvement][API Test] Add API tests for worker group related APIs#13936SbloodyS merged 8 commits intoapache:devfrom
Conversation
| HttpResponse createTenantHttpResponse = tenantPage.createTenant(sessionId, tenant, 1, ""); | ||
|
|
||
| Assertions.assertFalse(createTenantHttpResponse.body().success()); | ||
| Assertions.assertFalse(createTenantHttpResponse.getBody().getSuccess()); |
There was a problem hiding this comment.
Do you think getBody() is neater than body() 😉
There was a problem hiding this comment.
body() is neater maybe. It seems the configurations of lombok are different in api test and e2e module from those in other modules. I want them to be consistent.
| network: | ||
| driver: bridge | ||
| ipam: | ||
| config: | ||
| - subnet: 10.5.0.0/16 | ||
| gateway: 10.5.0.1 |
There was a problem hiding this comment.
We need to know the worker ip address when calling saveWorkerGroup. If we use a random ip, it would figure out there is no such worker and lead to failure.
...i-test-case/src/test/java/org/apache/dolphinscheduler/api.test/cases/WorkerGroupAPITest.java
Outdated
Show resolved
Hide resolved
...i-test-case/src/test/java/org/apache/dolphinscheduler/api.test/cases/WorkerGroupAPITest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #13936 +/- ##
============================================
- Coverage 38.86% 38.20% -0.67%
+ Complexity 4455 4436 -19
============================================
Files 1158 1220 +62
Lines 42439 42698 +259
Branches 4780 4734 -46
============================================
- Hits 16494 16311 -183
- Misses 24123 24584 +461
+ Partials 1822 1803 -19
... and 42 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
Purpose of the pull request
worker grouprelated APIsBrief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md