Skip to content

Use MDC to filter task instance log#13673

Merged
ruanwenjun merged 3 commits intoapache:devfrom
ruanwenjun:dev_wenjun_useMDCToCollectTaskInstanceLog
Mar 6, 2023
Merged

Use MDC to filter task instance log#13673
ruanwenjun merged 3 commits intoapache:devfrom
ruanwenjun:dev_wenjun_useMDCToCollectTaskInstanceLog

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun commented Mar 5, 2023 •
edited
Loading

Purpose of the pull request

close #13674

  • Remove the regex mapping of each log, use MDC to mark the task instance log.
  • Remove LoggerUtils

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun removed the backend label Mar 5, 2023
@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Mar 5, 2023
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Mar 5, 2023
@ruanwenjun ruanwenjun changed the title Use MDC to collect task instance log Use MDC to filter task instance log Mar 5, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_useMDCToCollectTaskInstanceLog branch from ee44934 to 7dc451f Compare March 5, 2023 11:00
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_useMDCToCollectTaskInstanceLog branch from 7dc451f to 3f82b67 Compare March 5, 2023 11:10
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_useMDCToCollectTaskInstanceLog branch from 3f82b67 to 0a573b1 Compare March 5, 2023 11:21
caishunfeng
caishunfeng previously approved these changes Mar 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nip

kezhenxu94
kezhenxu94 previously approved these changes Mar 6, 2023
View reviewed changes
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_useMDCToCollectTaskInstanceLog branch from 77cbcc4 to af0cf35 Compare March 6, 2023 05:40
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_useMDCToCollectTaskInstanceLog branch 2 times, most recently from bb61358 to 81bf327 Compare March 6, 2023 08:25
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_useMDCToCollectTaskInstanceLog branch from 81bf327 to 0e0ccf4 Compare March 6, 2023 08:51
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 6, 2023 •
edited
Loading

Codecov Report

Merging #13673 (b8893c5) into dev (fd72088) will decrease coverage by 0.10%.
The diff coverage is 20.85%.

❗ Current head b8893c5 differs from pull request most recent head 0e0ccf4. Consider uploading reports for the commit 0e0ccf4 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13673      +/-   ##
============================================
- Coverage     39.15%   39.06%   -0.10%     
+ Complexity     4426     4415      -11     
============================================
  Files          1129     1127       -2     
  Lines         42121    42052      -69     
  Branches       4776     4772       -4     
============================================
- Hits          16491    16426      -65     
+ Misses        23814    23811       -3     
+ Partials       1816     1815       -1
Impacted Files Coverage Δ
...heduler/api/service/impl/ResourcesServiceImpl.java 38.45% <ø> (-0.06%) ⬇️
...r/server/master/processor/StateEventProcessor.java 0.00% <0.00%> (ø)
...er/server/master/processor/TaskEventProcessor.java 0.00% <0.00%> (ø)
...master/processor/TaskExecuteResponseProcessor.java 0.00% <0.00%> (ø)
...r/server/master/processor/TaskRecallProcessor.java 0.00% <0.00%> (ø)
...ter/processor/queue/StateEventResponseService.java 0.00% <0.00%> (ø)
...er/master/processor/queue/TaskExecuteRunnable.java 0.00% <0.00%> (ø)
...uler/server/master/runner/EventExecuteService.java 0.00% <0.00%> (ø)
...server/master/runner/MasterSchedulerBootstrap.java 0.00% <0.00%> (ø)
.../server/master/runner/StateWheelExecuteThread.java 0.40% <0.00%> (ø)
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

24.7% 24.7% Coverage
0.0% 0.0% Duplication

@ruanwenjun ruanwenjun merged commit c9066e8 into apache:dev Mar 6, 2023
@ruanwenjun ruanwenjun deleted the dev_wenjun_useMDCToCollectTaskInstanceLog branch March 6, 2023 09:44
@rickchengx rickchengx mentioned this pull request Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Radeity Radeity Radeity left review comments

@caishunfeng caishunfeng caishunfeng approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@ruanwenjun ruanwenjun

Labels

backend improvement make more easy to user or prompt friendly

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Improvement][Log] Remove use regex to filter the task instance log.

5 participants

@ruanwenjun @codecov-commenter @caishunfeng @kezhenxu94 @Radeity