Skip to content

[Improvement][Style] Update spotless junit4 check scope#12450

Merged
EricGao888 merged 1 commit intoapache:devfrom
EricGao888:Update-spotless-junit4-check-scope
Oct 20, 2022
Merged

[Improvement][Style] Update spotless junit4 check scope#12450
EricGao888 merged 1 commit intoapache:devfrom
EricGao888:Update-spotless-junit4-check-scope

Conversation

@EricGao888
Copy link
Copy Markdown
Member

@EricGao888 EricGao888 commented Oct 19, 2022

Purpose of the pull request

Brief change log

  • Already described above.

Verify this pull request

  • Verified manually.

@EricGao888 EricGao888 self-assigned this Oct 19, 2022
@EricGao888 EricGao888 added the improvement make more easy to user or prompt friendly label Oct 19, 2022
@EricGao888 EricGao888 modified the milestones: 3.1.1, 3.2.0 Oct 19, 2022
@EricGao888 EricGao888 marked this pull request as ready for review October 19, 2022 15:25
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 19, 2022 •
edited
Loading

Codecov Report

Merging #12450 (317d406) into dev (97edc7d) will increase coverage by 0.13%.
The diff coverage is 65.86%.

❗ Current head 317d406 differs from pull request most recent head f1712a6. Consider uploading reports for the commit f1712a6 to get more accurate results

@@             Coverage Diff              @@
##                dev   #12450      +/-   ##
============================================
+ Coverage     39.23%   39.36%   +0.13%     
  Complexity     4213     4213              
============================================
  Files          1040     1040              
  Lines         38793    39157     +364     
  Branches       4462     4482      +20     
============================================
+ Hits          15219    15416     +197     
- Misses        21800    21964     +164     
- Partials       1774     1777       +3
Impacted Files Coverage Δ
...plugin/alert/dingtalk/DingTalkParamsConstants.java 0.00% <ø> (ø)
...cheduler/plugin/alert/email/EmailAlertChannel.java 47.61% <ø> (ø)
...inscheduler/plugin/alert/email/EmailConstants.java 0.00% <ø> (ø)
...eduler/plugin/alert/email/MailParamsConstants.java 0.00% <ø> (ø)
...olphinscheduler/plugin/alert/email/MailSender.java 50.68% <0.00%> (-0.35%) ⬇️
...gin/alert/email/exception/AlertEmailException.java 50.00% <ø> (ø)
...ugin/alert/email/template/DefaultHTMLTemplate.java 79.24% <0.00%> (-1.53%) ⬇️
...eduler/plugin/alert/feishu/FeiShuAlertChannel.java 16.66% <ø> (ø)
...ler/plugin/alert/feishu/FeiShuParamsConstants.java 0.00% <ø> (ø)
...hinscheduler/plugin/alert/feishu/FeiShuSender.java 46.55% <0.00%> (-1.24%) ⬇️
... and 504 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 33 Code Smells

48.8% 48.8% Coverage
0.8% 0.8% Duplication

@EricGao888 EricGao888 mentioned this pull request Oct 20, 2022
Merged
@EricGao888 EricGao888 merged commit 0a6e8af into apache:dev Oct 20, 2022
@EricGao888 EricGao888 changed the title [Improvement][Style] Update-spotless-junit4-check-scope [Improvement][Style] Update spotless junit4 check scope Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

Assignees

@EricGao888 EricGao888

Labels

backend improvement make more easy to user or prompt friendly

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Migration][Test] jUnit4 -> jUnit5 UT cases migration

3 participants

@EricGao888 @codecov-commenter @kezhenxu94