Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.60%. Comparing base (875682d) to head (928e5d5).
⚠️ Report is 1607 commits behind head on dev.

@@             Coverage Diff              @@
##                dev   #12311      +/-   ##
============================================
- Coverage     38.62%   38.60%   -0.02%     
- Complexity     4101     4104       +3     
============================================
  Files          1031     1031              
  Lines         38459    38459              
  Branches       4404     4402       -2     
============================================
- Hits          14854    14848       -6     
- Misses        21872    21881       +9     
+ Partials       1733     1730       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Currently we use check in CI but apply in pre-commit hook as execution goal of Spotless, see:

I'm thinking about changing the apply in pre-commit hook to check. The reason is if I add a regex step to block import org.powermock.*, contributors may get quite confused when pre-commit hook automatically deletes the import, just the same as the wildcard imports we discussed before: #11458 (comment)

WDYT @kezhenxu94 @zhongjiajie

I'm thinking about changing the apply in pre-commit hook to check. The reason is if I add a regex step to block import org.powermock.*, contributors may get quite confused when pre-commit hook automatically deletes the import, just the same as the wildcard imports we discussed before: #11458 (comment)

WDYT @kezhenxu94 @zhongjiajie

Sounds good to me

Currently we use check in CI but apply in pre-commit hook as execution goal of Spotless, see:

dolphinscheduler/pom.xml

Lines 679 to 686 in 04e1b88

	<executions>
	<execution>
	<goals>
	<goal>check</goal>
	</goals>
	<phase>compile</phase>
	</execution>
	</executions>

dolphinscheduler/.pre-commit-config.yaml

Lines 58 to 65 in 04e1b88

	- repo: local
	hooks:
	# Spotless Hooks
	- id: spotless
	name: spotless lint
	entry: ./mvnw spotless:apply
	language: script
	pass_filenames: false

I'm thinking about changing the apply in pre-commit hook to check. The reason is if I add a regex step to block import org.powermock.*, contributors may get quite confused when pre-commit hook automatically deletes the import, just the same as the wildcard imports we discussed before: #11458 (comment)

WDYT @kezhenxu94 @zhongjiajie

+1 for me

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

PTAL when available, thx~ @kezhenxu94 @caishunfeng @ruanwenjun @SbloodyS @zhongjiajie