Codecov Report

Merging #11793 (69bd990) into dev (4283cfd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #11793      +/-   ##
============================================
- Coverage     39.60%   39.58%   -0.02%     
  Complexity     4693     4693              
============================================
  Files          1014     1014              
  Lines         37952    37960       +8     
  Branches       4243     4245       +2     
============================================
- Hits          15030    15027       -3     
- Misses        21315    21326      +11     
  Partials       1607     1607              

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

I found the UT case WorkflowExecuteRunnableTest.testCheckSerialProcess, can you add a UT case for it?

I found the UT case WorkflowExecuteRunnableTest.testCheckSerialProcess, can you add a UT case for it?

@caishunfeng Of course. I will take a look. Thanks for the reminder : )

LGTM, it will be better if you can add UT.

Sure, I'm working on it.

Refactored some code for better readability and testability. Related unit tests added : ) PTAL @ruanwenjun @caishunfeng @SbloodyS @stalary

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

59.3% Coverage
0.0% Duplication

According to the docs about this feature, I think there are disagreements.

@lenboo May I ask whether the continue strategy was designed only for parallel execution, or there is an incorrect description in docs? If the latter, I will fix the docs. If the former, we need further discussion. However, IMHO, I think continue strategy should not only work for parallel. Sometimes we need clean up tasks. As described in issue.

According to the docs about this feature, I think there are disagreements.

@lenboo May I ask whether the continue strategy was designed only for parallel execution, or there is an incorrect description in docs? If the latter, I will fix the docs. If the former, we need further discussion. However, IMHO, I think continue strategy should not only work for parallel. Sometimes we need clean up tasks. As described in issue.

• Yes, the continue strategy was designed only for parallel tasks.
• I can understand the scenario you mentioned. Indeed, we need solution to this scenario in another discussion.

According to the docs about this feature, I think there are disagreements.

@lenboo May I ask whether the continue strategy was designed only for parallel execution, or there is an incorrect description in docs? If the latter, I will fix the docs. If the former, we need further discussion. However, IMHO, I think continue strategy should not only work for parallel. Sometimes we need clean up tasks. As described in issue.

• Yes, the continue strategy was designed only for parallel tasks.
• I can understand the scenario you mentioned. Indeed, we need solution to this scenario in another discussion.

@lenboo Thanks for the reply. I've add the topic to community bi-weekly conference topic list, looking forward to the discussion tonight : )

I'm closing it temporarily. Will submit a design later.