[Improvement][Metrics] Add metrics for alert server#11240
[Improvement][Metrics] Add metrics for alert server#11240EricGao888 merged 8 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #11240 +/- ##
============================================
+ Coverage 40.18% 40.22% +0.04%
+ Complexity 4951 4838 -113
============================================
Files 988 974 -14
Lines 37712 37315 -397
Branches 4145 4141 -4
============================================
- Hits 15153 15010 -143
+ Misses 21020 20763 -257
- Partials 1539 1542 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Coverage seems 0% for this PR, I'm not sure whether it is meaningful to find a way to cover those metrics related code.
|
| public final class AlertServerMetrics { | ||
|
|
||
| private AlertServerMetrics() { | ||
| throw new UnsupportedOperationException("Utility class"); |
There was a problem hiding this comment.
Use @UtilityClass annotation in this class to reduce these boilerplate codes
There was a problem hiding this comment.
Sure, thx for the suggestion. Will update it.
There was a problem hiding this comment.
Besides constructors, it looks like @UtilityClass automatically marks all fields and methods in the class as static final. Should we remove all of them during refactoring? Or keep those static final along with @UtilityClass for readability?
https://projectlombok.org/features/experimental/UtilityClass
WDYT @kezhenxu94
There was a problem hiding this comment.
I prefer to remove them. Utility class annotation takes care of all the conventions of a utility class
|
Kudos, SonarCloud Quality Gate passed! |
|
@kezhenxu94 @ruanwenjun Could you please take another look when available? Thanks~ |
Purpose of the pull request
Brief change log
Verify this pull request