Skip to content

[Feature][Task Plugin] Enable users to switch endpoints in zeppelin tasks#10925

Merged
zhuangchong merged 3 commits intoapache:devfrom
EricGao888:Fix-9814-zeppelin-endpoint
Jul 15, 2022
Merged

[Feature][Task Plugin] Enable users to switch endpoints in zeppelin tasks#10925
zhuangchong merged 3 commits intoapache:devfrom
EricGao888:Fix-9814-zeppelin-endpoint

Conversation

@EricGao888
Copy link
Copy Markdown
Member

@EricGao888 EricGao888 commented Jul 13, 2022

Purpose of the pull request

Brief change log

  • Remove zeppelin endpoint config from common.properties.
  • Enable users to configure zeppelin endpoint in zeppelin tasks to trigger jobs from different zeppelin instances.
  • Update related docs.

Verify this pull request

  • Verified by UT and manual tests.

@EricGao888 EricGao888 self-assigned this Jul 13, 2022
@EricGao888 EricGao888 added UI ui and front end related backend improvement make more easy to user or prompt friendly document labels Jul 13, 2022
@EricGao888 EricGao888 added this to the 3.1.0-alpha milestone Jul 13, 2022
@EricGao888 EricGao888 mentioned this pull request Jul 13, 2022
Closed
8 tasks
@EricGao888 EricGao888 marked this pull request as draft July 13, 2022 07:31
@EricGao888 EricGao888 marked this pull request as ready for review July 13, 2022 10:00
EricGao888
EricGao888 commented Jul 14, 2022
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #10925 (ded2a99) into dev (427c585) will decrease coverage by 0.01%.
The diff coverage is 60.81%.

❗ Current head ded2a99 differs from pull request most recent head 9785cdc. Consider uploading reports for the commit 9785cdc to get more accurate results

@@             Coverage Diff              @@
##                dev   #10925      +/-   ##
============================================
- Coverage     40.31%   40.30%   -0.02%     
  Complexity     4858     4858              
============================================
  Files           943      943              
  Lines         36994    37019      +25     
  Branches       4059     4061       +2     
============================================
+ Hits          14914    14920       +6     
- Misses        20578    20596      +18     
- Partials       1502     1503       +1
Impacted Files Coverage Δ
...org/apache/dolphinscheduler/alert/AlertConfig.java 0.00% <0.00%> (ø)
...he/dolphinscheduler/dao/entity/TaskDefinition.java 71.65% <ø> (ø)
...master/processor/TaskExecuteResponseProcessor.java 0.00% <0.00%> (ø)
.../master/processor/TaskExecuteRunningProcessor.java 22.22% <0.00%> (-2.78%) ⬇️
.../server/master/runner/WorkflowExecuteRunnable.java 7.79% <0.00%> (-0.02%) ⬇️
...olphinscheduler/plugin/task/api/TaskConstants.java 0.00% <ø> (ø)
...inscheduler/plugin/task/zeppelin/ZeppelinTask.java 48.05% <46.15%> (-0.64%) ⬇️
...permission/ResourcePermissionCheckServiceImpl.java 67.44% <50.00%> (-0.82%) ⬇️
...duler/plugin/task/zeppelin/ZeppelinParameters.java 81.25% <60.00%> (-3.37%) ⬇️
...che/dolphinscheduler/alert/AlertSenderService.java 54.74% <66.66%> (+0.41%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 427c585...9785cdc. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

54.5% 54.5% Coverage
0.0% 0.0% Duplication

@EricGao888 EricGao888 requested a review from zhuangchong July 14, 2022 13:05
zhuangchong
zhuangchong approved these changes Jul 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit a38fa34 into apache:dev Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhuangchong zhuangchong zhuangchong approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@EricGao888 EricGao888

Labels

backend document improvement make more easy to user or prompt friendly UI ui and front end related

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@EricGao888 @codecov-commenter @zhuangchong