[Feature][Api] Refactor org.apache.dolphinscheduler.api.controller.ProjectController by tracehh · Pull Request #10832 · apache/dolphinscheduler

tracehh · 2022-07-07T08:43:48Z

Purpose of the pull request

…ojectController

SbloodyS · 2022-07-07T08:45:28Z

Hi @tracehh , please associate the issue.

SbloodyS · 2022-07-07T08:49:34Z

see issue: #10489

to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.

tracehh · 2022-07-07T08:57:58Z

Get it, thanks @SbloodyS

…ller

codecov-commenter · 2022-07-11T03:18:28Z

Codecov Report

Merging #10832 (a59e4b4) into dev (65d2b8f) will increase coverage by 0.03%.
The diff coverage is 67.69%.

@@             Coverage Diff              @@
##                dev   #10832      +/-   ##
============================================
+ Coverage     40.35%   40.39%   +0.03%     
- Complexity     4865     4887      +22     
============================================
  Files           943      953      +10     
  Lines         37062    37142      +80     
  Branches       4068     4070       +2     
============================================
+ Hits          14958    15005      +47     
- Misses        20601    20629      +28     
- Partials       1503     1508       +5

Impacted Files	Coverage Δ
...cheduler/api/dto/project/ProjectCreateRequest.java	`0.00% <0.00%> (ø)`
.../api/dto/project/ProjectDeleteBooleanResponse.java	`0.00% <0.00%> (ø)`
...heduler/api/service/impl/SchedulerServiceImpl.java	`8.55% <0.00%> (ø)`
...scheduler/api/dto/project/ProjectQueryRequest.java	`50.00% <50.00%> (ø)`
...hinscheduler/api/controller/ProjectController.java	`68.75% <66.66%> (+0.75%)`	⬆️
.../apache/dolphinscheduler/api/dto/PageQueryDto.java	`66.66% <66.66%> (ø)`
...nscheduler/api/controller/ProjectV2Controller.java	`67.85% <67.85%> (ø)`
...ler/api/dto/project/ProjectListPagingResponse.java	`71.42% <71.42%> (ø)`
...scheduler/api/dto/project/ProjectListResponse.java	`71.42% <71.42%> (ø)`
...phinscheduler/api/dto/project/ProjectResponse.java	`71.42% <71.42%> (ø)`
... and 7 more

tracehh · 2022-07-11T09:24:29Z

@caishunfeng please review it, thx

caishunfeng

LGTM, but UT is missing, please add some UT of it.

SbloodyS

I think what you describe in #10489 is you want to refactor the whole ProjectController.

There seems to be a lot missing now.

...eduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectV2Controller.java

...uler-api/src/main/java/org/apache/dolphinscheduler/api/dto/project/ProjectCreateRequest.java

zhongjiajie · 2022-07-14T15:05:07Z

Hi @tracehh It is seem your UT failed, could you please take a look of the failed tests?

...eduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectV2Controller.java

tracehh · 2022-07-18T05:45:11Z

@caishunfeng @zhongjiajie please review and if it can merge

...duler-api/src/main/java/org/apache/dolphinscheduler/api/dto/project/ProjectListResponse.java

...api/src/main/java/org/apache/dolphinscheduler/api/dto/project/ProjectListPagingResponse.java

.../src/main/java/org/apache/dolphinscheduler/api/dto/project/ProjectDeleteBooleanResponse.java

...duler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectServiceImpl.java

tracehh · 2022-07-19T00:58:50Z

PTAL @caishunfeng @ruanwenjun @zhongjiajie

...duler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectServiceImpl.java

...ler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/SchedulerServiceImpl.java

...eduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectV2Controller.java

...scheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/project/ProjectResponse.java

sonarqubecloud · 2022-07-22T11:52:45Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
0 Security Hotspots
71 Code Smells

34.8% Coverage
0.0% Duplication

zhongjiajie

LGTM, do your guys have other option? @caishunfeng and @SbloodyS

caishunfeng

+1

SbloodyS

+1

[Feature][Api] Refactor org.apache.dolphinscheduler.api.controller.Pr…

efd0105

…ojectController

tracehh requested review from SbloodyS and caishunfeng as code owners July 7, 2022 08:43

tracehh changed the title ~~[Feature][Api] Refactor org.apache.dolphinscheduler.api.controller.Pr…~~ [Feature][Api] Refactor org.apache.dolphinscheduler.api.controller.ProjectController Jul 7, 2022

SbloodyS assigned tracehh Jul 7, 2022

SbloodyS added feature new feature backend refactor labels Jul 7, 2022

SbloodyS added this to the 4.0.0-alpha milestone Jul 7, 2022

xuhaihui added 2 commits July 11, 2022 10:14

[Feature][Api] refactor dolphinscheduler.api.controller.ProjectContro…

7e9921f

…ller

[Feature][Api] refactor api.controller.ProjectController

247b02d

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

690ac2e

caishunfeng reviewed Jul 12, 2022

View reviewed changes

SbloodyS reviewed Jul 12, 2022

View reviewed changes

xuhaihui added 4 commits July 12, 2022 09:57

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

196b74e

[Feature][Api] Refactor ProjectController

3881ce8

[Feature][Api] Refactor api ProjectController

128f35a

[Feature][Api] Refactor ProjectController-add ut

79a5876

zhongjiajie reviewed Jul 12, 2022

View reviewed changes

...uler-api/src/main/java/org/apache/dolphinscheduler/api/dto/project/ProjectCreateRequest.java Outdated Show resolved Hide resolved

xuhaihui added 2 commits July 14, 2022 17:02

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

7eece71

fix: use lombok

994bfbd

xuhaihui added 3 commits July 15, 2022 09:47

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

30c4a13

fix ut

667d66a

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

5b0d9dc

xuhaihui added 2 commits July 15, 2022 17:25

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

8517f2b

fix ut

0e6db7c

SbloodyS reviewed Jul 16, 2022

View reviewed changes

xuhaihui added 2 commits July 18, 2022 09:16

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

dee31b4

fix review suggests

869a631

SbloodyS reviewed Jul 18, 2022

View reviewed changes

xuhaihui added 3 commits July 18, 2022 17:01

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

975a976

fix review idea

1c7a6e2

fix use lombok

09c288d

SbloodyS reviewed Jul 18, 2022

View reviewed changes

...duler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectServiceImpl.java Outdated Show resolved Hide resolved

...duler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectServiceImpl.java Outdated Show resolved Hide resolved

fix format issue

79819f5

SbloodyS reviewed Jul 18, 2022

View reviewed changes

...duler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectServiceImpl.java Outdated Show resolved Hide resolved

xuhaihui added 2 commits July 18, 2022 18:03

fix fullname issue

7a1892a

fix fullname

323563f

caishunfeng reviewed Jul 20, 2022

View reviewed changes

...duler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectServiceImpl.java Outdated Show resolved Hide resolved

...ler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/SchedulerServiceImpl.java Show resolved Hide resolved

xuhaihui added 3 commits July 20, 2022 10:22

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

b94c886

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

2b391e0

fix review issue

a59e4b4

SbloodyS reviewed Jul 22, 2022

View reviewed changes

...eduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectV2Controller.java Outdated Show resolved Hide resolved

...scheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/project/ProjectResponse.java Show resolved Hide resolved

xuhaihui added 4 commits July 22, 2022 15:07

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

44fa0f4

fix review suggests

05a865a

Merge branch 'dev' of github.com:apache/dolphinscheduler into dev

18dae0d

fix uts

9503fb4

zhongjiajie approved these changes Jul 25, 2022

View reviewed changes

caishunfeng approved these changes Jul 26, 2022

View reviewed changes

SbloodyS approved these changes Jul 26, 2022

View reviewed changes

SbloodyS merged commit 8004e97 into apache:dev Jul 26, 2022

Conversation

tracehh commented Jul 7, 2022 • edited by SbloodyS Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of the pull request

Uh oh!

SbloodyS commented Jul 7, 2022

Uh oh!

SbloodyS commented Jul 7, 2022

Uh oh!

tracehh commented Jul 7, 2022

Uh oh!

codecov-commenter commented Jul 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tracehh commented Jul 11, 2022

Uh oh!

caishunfeng left a comment

Choose a reason for hiding this comment

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zhongjiajie commented Jul 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tracehh commented Jul 18, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tracehh commented Jul 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 22, 2022

Uh oh!

zhongjiajie left a comment

Choose a reason for hiding this comment

Uh oh!

caishunfeng left a comment

Choose a reason for hiding this comment

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tracehh commented Jul 7, 2022 •

edited by SbloodyS

Loading

codecov-commenter commented Jul 11, 2022 •

edited

Loading