[Feature][Task Plugin] Add mlflow task plugin for MLops scenario.#10036
Merged
caishunfeng merged 22 commits intoapache:devfrom May 19, 2022
Merged
[Feature][Task Plugin] Add mlflow task plugin for MLops scenario.#10036caishunfeng merged 22 commits intoapache:devfrom
caishunfeng merged 22 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #10036 +/- ##
============================================
+ Coverage 40.87% 41.11% +0.24%
- Complexity 4633 4686 +53
============================================
Files 839 844 +5
Lines 34005 34342 +337
Branches 3769 3850 +81
============================================
+ Hits 13898 14119 +221
- Misses 18777 18862 +85
- Partials 1330 1361 +31
Continue to review full report at Codecov.
|
zhongjiajie
reviewed
May 15, 2022
...ask-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowConstants.java
Outdated
Show resolved
Hide resolved
Member
|
Please run the prettier directive to format the code |
kezhenxu94
reviewed
May 16, 2022
...ask-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowConstants.java
Outdated
Show resolved
Hide resolved
...duler-task-mlflow/src/test/java/org/apache/dolphinler/plugin/task/mlflow/MlflowTaskTest.java
Outdated
Show resolved
Hide resolved
...duler-task-mlflow/src/test/java/org/apache/dolphinler/plugin/task/mlflow/MlflowTaskTest.java
Outdated
Show resolved
Hide resolved
...duler-task-mlflow/src/test/java/org/apache/dolphinler/plugin/task/mlflow/MlflowTaskTest.java
Outdated
Show resolved
Hide resolved
Tianqi-Dotes
previously approved these changes
May 18, 2022
Member
Author
|
I have dealt with the problems above. PTAL @kezhenxu94 @zhongjiajie @caishunfeng , Thanks. |
6 tasks
# Conflicts: # docs/configs/docsdev.js # dolphinscheduler-task-plugin/dolphinscheduler-task-all/pom.xml # dolphinscheduler-ui/src/views/projects/task/components/node/tasks/index.ts # dolphinscheduler-ui/src/views/projects/task/components/node/types.ts # dolphinscheduler-ui/src/views/projects/task/constants/task-type.ts
68b1afd
|
Kudos, SonarCloud Quality Gate passed! |
caishunfeng
approved these changes
May 18, 2022
Contributor
caishunfeng
left a comment
There was a problem hiding this comment.
LGTM, it's a good feature, thanks for your contribution.
Member
Author
I have rebased the upstream dev, PTAL, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Add MLflow task plugin to enable Dolphin users to schedule MLflow.
This PR relates to #9725.
Because I want to continue enriching the capabilities of this plugin, leave the issue open for now.
Brief change log
Verify this pull request
Verified by unit test.