-
Notifications
You must be signed in to change notification settings - Fork 5k
[Bug] [MasterServer] master will still work when it lose zk connection #7004
Copy link
Copy link
Closed
Labels
Waiting for replyWaiting for replyWaiting for replybugSomething isn't workingSomething isn't working
Description
Search before asking
- I had searched in the issues and found no similar issues.
What happened
Now when master lose zk connection, it will still find commands and handle processInstance, because the condition ServerNodeManager.MASTER_SIZE and slot is not changed. So it may happen two masters have the same slot, and
I found MasterRegistryClient addConnectionStateListener when registry:
registryClient.addConnectionStateListener(newState -> { if (newState == ConnectionState.RECONNECTED || newState == ConnectionState.SUSPENDED) { registryClient.persistEphemeral(localNodePath, ""); } });
What you expected to happen
When master lose zk connection, stop processing command until reconnect.
How to reproduce
none
Anything else
No response
Version
dev
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Waiting for replyWaiting for replyWaiting for replybugSomething isn't workingSomething isn't working