Skip to content

Commit ce6fd60

Browse files
author
Jackie
committed
[improvement] fix bug
1 parent 5481dc9 commit ce6fd60

2 files changed

Lines changed: 7 additions & 11 deletions

File tree

dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/TaskGroupMapperTest.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@
2020
import org.apache.dolphinscheduler.dao.BaseDaoTest;
2121
import org.apache.dolphinscheduler.dao.entity.TaskGroup;
2222

23+
import java.util.ArrayList;
2324
import java.util.Date;
25+
import java.util.List;
2426

2527
import org.junit.jupiter.api.Assertions;
2628
import org.junit.jupiter.api.Test;
27-
import org.mockito.Mockito;
29+
2830
import org.slf4j.Logger;
2931
import org.slf4j.LoggerFactory;
3032
import org.springframework.beans.factory.annotation.Autowired;
@@ -87,9 +89,12 @@ public void testCheckName() {
8789
public void testQueryTaskGroupPaging() {
8890
TaskGroup taskGroup = insertOne();
8991
Page<TaskGroup> page = new Page(1, 3);
92+
List<Integer> ids = new ArrayList<>();
93+
ids.add(1);
94+
ids.add(2);
9095
IPage<TaskGroup> taskGroupIPage = taskGroupMapper.queryTaskGroupPaging(
9196
page,
92-
Mockito.anyList(),
97+
ids,
9398
taskGroup.getName(), taskGroup.getStatus());
9499

95100
Assertions.assertEquals(taskGroupIPage.getTotal(), 1);

dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/upgrade/WorkerGroupDaoTest.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,6 @@ public class WorkerGroupDaoTest {
3939
@Autowired
4040
protected DataSource dataSource;
4141

42-
@Test
43-
public void testQueryQueryAllOldWorkerGroup() throws Exception {
44-
WorkerGroupDao workerGroupDao = new WorkerGroupDao();
45-
46-
Map<Integer, String> workerGroupMap = workerGroupDao.queryAllOldWorkerGroup(dataSource.getConnection());
47-
48-
Assertions.assertTrue(workerGroupMap.size() > 0);
49-
}
50-
5142
@Test
5243
public void testQueryQueryAllOldWorkerGroupException() throws Exception {
5344
Assertions.assertThrows(Exception.class, () -> {

0 commit comments

Comments
 (0)