Skip to content

Conversation

@gamife
Copy link
Contributor

@gamife gamife commented Feb 10, 2022

No description provided.

@gamife gamife force-pushed the feature/for_update branch from 12de47b to 500fbf4 Compare February 14, 2022 01:40
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gamife -- other than the struct name this looks good to go.

@coveralls
Copy link

coveralls commented Feb 16, 2022

Pull Request Test Coverage Report for Build 1862153061

  • 28 of 28 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 90.612%

Totals Coverage Status
Change from base Build 1858728297: 0.03%
Covered Lines: 7133
Relevant Lines: 7872

💛 - Coveralls

@baoyachi
Copy link

What progress has been made so far? It seems that it can be merged

@houqp
Copy link
Member

houqp commented Feb 24, 2022

I don't have merge access and @alamb is on vacation right now, let's wait a little bit more :)

@houqp
Copy link
Member

houqp commented Feb 24, 2022

actually, @Dandandan and @andygrove should be able to help review as well.

@Dandandan
Copy link
Contributor

Thanks a lot!

@Dandandan Dandandan merged commit 0b5178d into apache:main Feb 24, 2022
@alamb
Copy link
Contributor

alamb commented Feb 28, 2022

🎉

@alamb
Copy link
Contributor

alamb commented Feb 28, 2022

I'll try and make a sqlparser release sometime early next week too to pick up this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants