Skip to content

Conversation

@dharanad
Copy link
Contributor

@dharanad dharanad commented Jan 7, 2025

Which issue does this PR close?

Part of #1042

Rationale for this change

What changes are included in this PR?

How are these changes tested?

Signed-off-by: Dharan Aditya <dharan.aditya@gmail.com>
Signed-off-by: Dharan Aditya <dharan.aditya@gmail.com>
Signed-off-by: Dharan Aditya <dharan.aditya@gmail.com>
Signed-off-by: Dharan Aditya <dharan.aditya@gmail.com>
Signed-off-by: Dharan Aditya <dharan.aditya@gmail.com>
Introduced `ArrayMinMax` struct to handle both ArrayMin and ArrayMax functionalities, consolidating shared logic. Implemented evaluation logic, schema compatibility, and planner integration for `ArrayMinMax` expressions. This enhances functionality by providing min/max operations on list arrays.

Signed-off-by: Dharan Aditya <dharan.aditya@gmail.com>
@andygrove
Copy link
Member

@dharanad would it be possible to break this out into one PR per function? It will make reviews much easier.

@dharanad
Copy link
Contributor Author

@andygrove Sure i will break them into multiple PRs

@dharanad
Copy link
Contributor Author

Closing this PR. Will create seperate PR for each fn.

@dharanad dharanad closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants