Update to apache/arrow-datafusion#2578 #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
May 29, 2022
| let df = ctx.read_csv(table_name, options).await?; | ||
|
|
||
| let uri = format!("file:///{}.csv", table_name); | ||
| ctx.register_csv(table_name, &uri, options).await?; |
Contributor
Author
There was a problem hiding this comment.
Changing to using this method is necessary as otherwise it infers the ?table? as the table name, which seems to result in an additional projection appearing, not entirely sure why though...
This was referenced May 30, 2022
alamb
approved these changes
May 31, 2022
Contributor
alamb
left a comment
There was a problem hiding this comment.
The changes make sense to me
| clap = { version = "3", features = ["derive", "cargo"] } | ||
| datafusion = { git = "https://github.com/apache/arrow-datafusion", rev = "b6fb0dd52c2abd0f8e134aa46cc1571cc6a0971b" } | ||
| datafusion-proto = { git = "https://github.com/apache/arrow-datafusion", rev = "b6fb0dd52c2abd0f8e134aa46cc1571cc6a0971b" } | ||
| datafusion = { git = "https://github.com/apache/arrow-datafusion", rev = "fdb8fecf0ab475ba07dc0d15f7b53e25ccf30ee7" } |
Contributor
There was a problem hiding this comment.
@andygrove / @thinkharderdev -- what would you think about writing some script that automatically updates this pin rather than requiring datafusion developers manually make PRs?
We basically upgrade the DataFusion pin manually for IOx and while it takes times it seems to work for us -- for example https://github.com/influxdata/influxdb_iox/pull/4619
| let df = ctx.read_csv(table_name, options).await?; | ||
|
|
||
| let uri = format!("file:///{}.csv", table_name); | ||
| ctx.register_csv(table_name, &uri, options).await?; |
Contributor
|
I am going to merge this in because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
apache/datafusion#2578 contains breaking changes (introduces ListingTableUri)
What changes are included in this PR?
Updates Ballista with breaking changes
Are there any user-facing changes?
There are breaking changes to DataFusion