Minor: adjust visibility of LogicalPlan:: apply_subqueries and LogicalPlan::map_subueries
#9997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
1. looks good to me, but regarding 2. I'm not sure we need to remove those APIs: #9913 (comment). The |
LogicalPlan:: apply_subqueries and LogicalPlan::map_subueries
Contributor
Author
Makes sense -- I will make a new PR that makes them pub / adds docs |
Contributor
Author
|
#9998 for making them pub. I will document them as a follow on PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9994
Rationale for this change
These methods were introduced in #9913 by @peter-toth but I think they were part of a previous implementation and unused.
What changes are included in this PR?
apply_subqueriesandmap_subueriespubtransform_*functionsAre these changes tested?
CI
Are there any user-facing changes?
No (as the removed functions have not been released)