Minor: Run ScalarValue size test on aarch again #9728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #9725
Closes #.
Rationale for this change
The size of
ScalarValueappears to have changed on Linux to be the same as aarch64. Thus we can now run the ScalarValue size test again:See details here: https://github.com/apache/arrow-datafusion/pull/9725/files#r1534400422
The point of the test was to ensure that the size of ScalarValue didn't change with PRs, but the Rust compiler may change how types are laid out.
What changes are included in this PR?
Update comments and run the test on all platforms again
Are these changes tested?
Are there any user-facing changes?