Minor: return internal error rather than panic on unexpected error in COUNT DISTINCT #9712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Mar 20, 2024
comphead
reviewed
Mar 20, 2024
| assert_eq!(states.len(), 1, "array_agg states must be singleton!"); | ||
| let array = &states[0]; | ||
| let list_array = array.as_list::<i32>(); | ||
| for inner_array in list_array.iter() { |
Contributor
There was a problem hiding this comment.
should we just filter out Nones? just thinking
Contributor
Author
There was a problem hiding this comment.
I think filtering out nulls would potentially silently ignore errors
I think the rationale goes like
- This code is used to combine multiple partial results (the results of calling
Self::state()) - Since
Self::statenever returnsNone-- it always returnsOk(vec![ScalarValue::List(arr)])then this merge code should never receive aNone
comphead
reviewed
Mar 21, 2024
Co-authored-by: comphead <comphead@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #9679
Rationale for this change
@Omega359 pointed out that the use of
expectwould panic on unexpected results: #9679 (comment)What changes are included in this PR?
Change a panic into an internal error
Are these changes tested?
No (it is "impossible" to hit this code)
Are there any user-facing changes?
Better UX on unexpected error