Fix COPY TO failing on passing format options through CLI #9709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 20, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @tinfoil-knight
I tested this out locally
before this PR:
❯ COPY (select * from (values (1))) to '/tmp/foo.parquet' STORED AS PARQUET OPTIONS ('format.compression' snappy);
Invalid or Unsupported Configuration: Specify a format for TableOptionsAfter this PR:
DataFusion CLI v36.0.0
❯ COPY (select * from (values (1))) to '/tmp/foo.parquet' STORED AS PARQUET OPTIONS ('format.compression' snappy);
+-------+
| count |
+-------+
| 1 |
+-------+
1 row in set. Query took 0.038 seconds.
Contributor
|
Thanks again @tinfoil-knight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9707 .
Rationale for this change
Please see the issue description for #9707 .
What changes are included in this PR?
We're getting the
formatfromformat_options& passing it toregister_object_store_and_config_extensionsso thatTableOptionsare set correctly.Are these changes tested?
There are very less tests for the
datafusion-clicrate. Testing this change would require setting up some sort of auto-cleanup like SQL Logic Tests for the COPY TO command. Let me know if we should do this now or open an issue separately for increasing the CLI test coverage.Are there any user-facing changes?
No. This PR just fixes what's expected to be working. No new changes.