Port ArrayDistinct to functions-array subcrate
#9549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
Member
|
Hi @erenavsarogullari , could you add a roundtrip test here? |
Member
Author
|
@Weijun-H Thanks for the review. It is added. |
Weijun-H
reviewed
Mar 11, 2024
ArrayDistinct to function-arrays subcrateArrayDistinct to functions-array subcrate
Weijun-H
approved these changes
Mar 12, 2024
Member
Weijun-H
left a comment
There was a problem hiding this comment.
LGTM! Thanks @erenavsarogullari 👍
jayzhan211
approved these changes
Mar 12, 2024
Contributor
jayzhan211
left a comment
There was a problem hiding this comment.
Thanks @erenavsarogullari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9545.
What changes are included in this PR?
This PR aims to do following changes in terms of Epic #9285:
1-
ArrayDistinctis ported tofunctions-arraysubcrate,2-
general_array_distinctis ported tokernels.rsbut could not be removed fromarray_expressions.rsdue to its legacy references: ref3-
ScalarUDFImpl. return_typehas been implemented to support input types:List,FixedSizeListandLargeList,4- Function Documentation is added.
Are these changes tested?
Yes, all
array.sltbasedarray_distincttests are passed.Are there any user-facing changes?
No