Skip to content

Conversation

@comphead
Copy link
Contributor

@comphead comphead commented Mar 8, 2024

Which issue does this PR close?

Closes #8370 .

Rationale for this change

Remove tech debt brought up by not supported cast from Float to Timestamp in arrow-rs. Now we can safely remove it

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Mar 8, 2024
@comphead comphead changed the title minor: use arrow-rs casting minor: use arrow-rs casting from Float to Timestamp Mar 8, 2024
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comphead comphead merged commit a68f1cb into apache:main Mar 8, 2024
@comphead
Copy link
Contributor Author

comphead commented Mar 8, 2024

Thanks @jayzhan211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor: small refactoring for ints/floats to timestamps conversions

2 participants