Port regexp_replace functions and related tests #9454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 5, 2024
Contributor
There was a problem hiding this comment.
This looks great @Lordworms -- thank you and congratulations on being the first to remove one of the modules from datafusion-physical-expressions 🏆
| itertools = { workspace = true } | ||
| log = { workspace = true } | ||
|
|
||
| regex = { version = "1.8" } |
Contributor
There was a problem hiding this comment.
Since this is only needed for the regular expressions, I think we can mark it optional like
Suggested change
| regex = { version = "1.8" } | |
| regex = { version = "1.8", optional = true } |
And then change this above from
regex_expressions = []to
regex_expressions = ["regex"]I'll do this in a follow on PR
| mod partitioning; | ||
| mod physical_expr; | ||
| pub mod planner; | ||
| #[cfg(feature = "regex_expressions")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9328
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?